From 3b26f7e53bbe287deb57c75c796f17c9a82229a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krzysztof=20Kosi=C5=84ski?= Date: Tue, 9 Jan 2024 08:38:41 -0800 Subject: [PATCH] Disable -Wfloat-equal in AppropriateResolution(). This function makes exact floating point that are correct in this context, but trigger the compiler warning. PiperOrigin-RevId: 596944060 Change-Id: I4bba3c2abcf3ac189107530978961955ad47d6f0 --- googletest/include/gtest/gtest-printers.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/googletest/include/gtest/gtest-printers.h b/googletest/include/gtest/gtest-printers.h index 1b12ef68..0007a2a9 100644 --- a/googletest/include/gtest/gtest-printers.h +++ b/googletest/include/gtest/gtest-printers.h @@ -552,6 +552,10 @@ int AppropriateResolution(FloatType val) { int full = std::numeric_limits::max_digits10; if (val < 0) val = -val; +#ifdef __GNUC__ +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wfloat-equal" +#endif if (val < 1000000) { FloatType mulfor6 = 1e10; if (val >= 100000.0) { // 100,000 to 999,999 @@ -595,6 +599,9 @@ int AppropriateResolution(FloatType val) { val) return 6; } +#ifdef __GNUC__ +#pragma GCC diagnostic pop +#endif return full; }