3party/googletest
0
0
Fork 0
mirror of https://github.com/google/googletest.git synced 2025-03-10 09:16:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Restore GTEST_ATTRIBUTE_PRINTF_ on ColoredPrintf

Browse Source 
This fixes build issues with GoogleTest when built with
-Wformat-nonliteral and unblocks updating GoogleTest in BoringSSL.

It was added in 53c478d639b8eebd2942e88266610ebc79c541f6, which caught
some bugs. Then it was moved to the header and accidentally dropped in
482ac6ee63429af2aa9c44f4e6427873fb68fb1f.
This commit is contained in:
David Benjamin 2021-01-06 12:01:34 -05:00
parent 389cb68b87
commit 28041f6428
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
googletest/src/gtest.cc
View File

@ -3269,7 +3269,8 @@ bool ShouldUseColor(bool stdout_is_tty) {
// This routine must actually emit the characters rather than return a string
// that would be colored when printed, as can be done on Linux.
static void ColoredPrintf(GTestColor color, const char* fmt, ...) {
GTEST_ATTRIBUTE_PRINTF_(2, 3)
static void ColoredPrintf(GTestColor color, const char *fmt, ...) {
va_list args;
va_start(args, fmt);