mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-27 15:21:13 +08:00
3663b7cbbe
This is a reland of 95e97a32eba4d505ab9591e683d2147c441eea48 Original change's description: > Use a relative address in .note.crashpad.info > > The desc value in the note is now the offset of CRASHPAD_INFO_SYMBOL > from desc. > > Making this note writable can trigger a linker error resulting in > the binary embedding .note.crashpad.info to be rejected by the > kernel during program loading. > > The error was observed with: > GNU ld (GNU Binutils for Debian) 2.30 > clang version 4.0.1-10 (tags/RELEASE_401/final) > Debian 4.17.17-1rodete2 > > When the note is made writable, crashpad_snapshot_test contains two > PT_LOAD segments which map to the same page. > > LOAD 0x0000000000000000 0x0000000000000000 0x0000000000000000 > 0x0000000000000258 0x0000000000000258 R 0x200000 > LOAD 0x0000000000000258 0x0000000000000258 0x0000000000000258 > 0x00000000002b84d8 0x00000000002b8950 RWE 0x200000 > > Executing this binary with the execv system call triggers a segfault > during program loading (an error can't be returned because the original > process vm has already been discarded). > > I suspect (I haven't set up a debuggable kernel) the failure occurs > while attempting to map the second load segment because its virtual > address, 0x258, is in the same page as the first load segment. > https://elixir.bootlin.com/linux/v4.17.17/source/fs/binfmt_elf.c#L380 > > The linker normally produces consecutive load segments where the second > segment is loaded 0x200000 bytes after the first, which I think is the > maximum expected page size. Modifying the test executable to load the > second segment at 0x1258 (4096 byte page size) allows program loading > to succeed (but of course crashes after control is given to it). > > Bug: crashpad:260 > Change-Id: I2b9f1e66e98919138baef3da991a9710bd970dc4 > Reviewed-on: https://chromium-review.googlesource.com/c/1292232 > Reviewed-by: Scott Graham <scottmg@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Joshua Peraza <jperaza@chromium.org> Bug: crashpad:260 Change-Id: I66713de84cc26c9119e0454d19c9c189263fe054 Reviewed-on: https://chromium-review.googlesource.com/c/1318066 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
212 lines
6.9 KiB
C++
212 lines
6.9 KiB
C++
// Copyright 2018 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "snapshot/elf/module_snapshot_elf.h"
|
|
|
|
#include <endian.h>
|
|
|
|
#include <algorithm>
|
|
|
|
#include "base/files/file_path.h"
|
|
#include "snapshot/crashpad_types/image_annotation_reader.h"
|
|
#include "util/misc/elf_note_types.h"
|
|
|
|
namespace crashpad {
|
|
namespace internal {
|
|
|
|
ModuleSnapshotElf::ModuleSnapshotElf(const std::string& name,
|
|
ElfImageReader* elf_reader,
|
|
ModuleSnapshot::ModuleType type,
|
|
ProcessMemoryRange* process_memory_range)
|
|
: ModuleSnapshot(),
|
|
name_(name),
|
|
elf_reader_(elf_reader),
|
|
process_memory_range_(process_memory_range),
|
|
crashpad_info_(),
|
|
type_(type),
|
|
initialized_() {}
|
|
|
|
ModuleSnapshotElf::~ModuleSnapshotElf() = default;
|
|
|
|
bool ModuleSnapshotElf::Initialize() {
|
|
INITIALIZATION_STATE_SET_INITIALIZING(initialized_);
|
|
|
|
if (!elf_reader_) {
|
|
LOG(ERROR) << "no elf reader";
|
|
return false;
|
|
}
|
|
|
|
// The data payload is only sizeof(VMAddress) in the note, but add a bit to
|
|
// account for the name, header, and padding.
|
|
constexpr ssize_t kMaxNoteSize = 256;
|
|
std::unique_ptr<ElfImageReader::NoteReader> notes =
|
|
elf_reader_->NotesWithNameAndType(CRASHPAD_ELF_NOTE_NAME,
|
|
CRASHPAD_ELF_NOTE_TYPE_CRASHPAD_INFO,
|
|
kMaxNoteSize);
|
|
std::string desc;
|
|
VMAddress info_address;
|
|
VMAddress desc_address;
|
|
if (notes->NextNote(nullptr, nullptr, &desc, &desc_address) ==
|
|
ElfImageReader::NoteReader::Result::kSuccess) {
|
|
VMOffset offset;
|
|
if (elf_reader_->Memory()->Is64Bit()) {
|
|
offset = *reinterpret_cast<VMOffset*>(&desc[0]);
|
|
} else {
|
|
int32_t offset32 = *reinterpret_cast<int32_t*>(&desc[0]);
|
|
offset = offset32;
|
|
}
|
|
info_address = desc_address + offset;
|
|
|
|
ProcessMemoryRange range;
|
|
if (range.Initialize(*elf_reader_->Memory())) {
|
|
auto info = std::make_unique<CrashpadInfoReader>();
|
|
if (info->Initialize(&range, info_address)) {
|
|
crashpad_info_ = std::move(info);
|
|
}
|
|
}
|
|
}
|
|
|
|
INITIALIZATION_STATE_SET_VALID(initialized_);
|
|
return true;
|
|
}
|
|
|
|
bool ModuleSnapshotElf::GetCrashpadOptions(CrashpadInfoClientOptions* options) {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
|
|
if (!crashpad_info_) {
|
|
return false;
|
|
}
|
|
|
|
options->crashpad_handler_behavior =
|
|
crashpad_info_->CrashpadHandlerBehavior();
|
|
options->system_crash_reporter_forwarding =
|
|
crashpad_info_->SystemCrashReporterForwarding();
|
|
options->gather_indirectly_referenced_memory =
|
|
crashpad_info_->GatherIndirectlyReferencedMemory();
|
|
options->indirectly_referenced_memory_cap =
|
|
crashpad_info_->IndirectlyReferencedMemoryCap();
|
|
return true;
|
|
}
|
|
|
|
std::string ModuleSnapshotElf::Name() const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
return name_;
|
|
}
|
|
|
|
uint64_t ModuleSnapshotElf::Address() const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
return elf_reader_->Address();
|
|
}
|
|
|
|
uint64_t ModuleSnapshotElf::Size() const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
return elf_reader_->Size();
|
|
}
|
|
|
|
time_t ModuleSnapshotElf::Timestamp() const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
return 0;
|
|
}
|
|
|
|
void ModuleSnapshotElf::FileVersion(uint16_t* version_0,
|
|
uint16_t* version_1,
|
|
uint16_t* version_2,
|
|
uint16_t* version_3) const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
*version_0 = 0;
|
|
*version_1 = 0;
|
|
*version_2 = 0;
|
|
*version_3 = 0;
|
|
}
|
|
|
|
void ModuleSnapshotElf::SourceVersion(uint16_t* version_0,
|
|
uint16_t* version_1,
|
|
uint16_t* version_2,
|
|
uint16_t* version_3) const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
*version_0 = 0;
|
|
*version_1 = 0;
|
|
*version_2 = 0;
|
|
*version_3 = 0;
|
|
}
|
|
|
|
ModuleSnapshot::ModuleType ModuleSnapshotElf::GetModuleType() const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
return type_;
|
|
}
|
|
|
|
void ModuleSnapshotElf::UUIDAndAge(crashpad::UUID* uuid, uint32_t* age) const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
*age = 0;
|
|
|
|
std::unique_ptr<ElfImageReader::NoteReader> notes =
|
|
elf_reader_->NotesWithNameAndType(ELF_NOTE_GNU, NT_GNU_BUILD_ID, 64);
|
|
std::string desc;
|
|
VMAddress desc_addr;
|
|
notes->NextNote(nullptr, nullptr, &desc, &desc_addr);
|
|
desc.insert(desc.end(), 16 - std::min(desc.size(), size_t{16}), '\0');
|
|
uuid->InitializeFromBytes(reinterpret_cast<const uint8_t*>(&desc[0]));
|
|
|
|
// TODO(scottmg): https://crashpad.chromium.org/bug/229. These are
|
|
// endian-swapped to match FileID::ConvertIdentifierToUUIDString() in
|
|
// Breakpad. This is necessary as this identifier is used for symbol lookup.
|
|
uuid->data_1 = htobe32(uuid->data_1);
|
|
uuid->data_2 = htobe16(uuid->data_2);
|
|
uuid->data_3 = htobe16(uuid->data_3);
|
|
}
|
|
|
|
std::string ModuleSnapshotElf::DebugFileName() const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
return base::FilePath(Name()).BaseName().value();
|
|
}
|
|
|
|
std::vector<std::string> ModuleSnapshotElf::AnnotationsVector() const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
return std::vector<std::string>();
|
|
}
|
|
|
|
std::map<std::string, std::string> ModuleSnapshotElf::AnnotationsSimpleMap()
|
|
const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
std::map<std::string, std::string> annotations;
|
|
if (crashpad_info_ && crashpad_info_->SimpleAnnotations()) {
|
|
ImageAnnotationReader reader(process_memory_range_);
|
|
reader.SimpleMap(crashpad_info_->SimpleAnnotations(), &annotations);
|
|
}
|
|
return annotations;
|
|
}
|
|
|
|
std::vector<AnnotationSnapshot> ModuleSnapshotElf::AnnotationObjects() const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
std::vector<AnnotationSnapshot> annotations;
|
|
if (crashpad_info_ && crashpad_info_->AnnotationsList()) {
|
|
ImageAnnotationReader reader(process_memory_range_);
|
|
reader.AnnotationsList(crashpad_info_->AnnotationsList(), &annotations);
|
|
}
|
|
return annotations;
|
|
}
|
|
|
|
std::set<CheckedRange<uint64_t>> ModuleSnapshotElf::ExtraMemoryRanges() const {
|
|
INITIALIZATION_STATE_DCHECK_VALID(initialized_);
|
|
return std::set<CheckedRange<uint64_t>>();
|
|
}
|
|
|
|
std::vector<const UserMinidumpStream*>
|
|
ModuleSnapshotElf::CustomMinidumpStreams() const {
|
|
return std::vector<const UserMinidumpStream*>();
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace crashpad
|