mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-31 01:43:03 +08:00
cc166d71f4
This is a follow-up to c8a016b99d97, following the post-landing discussion at https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7 base::size, and std::size that will eventually replace it when C++17 is assured, does not allow the size of non-static data members to be taken in constant expression context. The remaining uses of ArraySize are in: minidump/minidump_exception_writer.cc (×1) minidump/minidump_system_info_writer.cc (×2, also uses base::size) snapshot/cpu_context.cc (×4, also uses base::size) util/misc/arraysize_test.cc (×10, of course) The first of these occurs when initializing a constexpr variable. All others are in expressions used with static_assert. Includes: Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao f701716d9546 Add Windows ARM64 build target to mini_chromium 87a95a3d6ac2 Remove the arraysize macro 1f7255ead1f7 Placate MSVC in areas of base::size usage 737433ebade4 Add cast Bug: chromium:837308 Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19 Reviewed-on: https://chromium-review.googlesource.com/c/1396108 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
100 lines
3.0 KiB
C++
100 lines
3.0 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#include "util/misc/clock.h"
|
||
|
||
#include <sys/types.h>
|
||
|
||
#include <algorithm>
|
||
|
||
#include "base/format_macros.h"
|
||
#include "base/logging.h"
|
||
#include "base/stl_util.h"
|
||
#include "base/strings/stringprintf.h"
|
||
#include "gtest/gtest.h"
|
||
|
||
namespace crashpad {
|
||
namespace test {
|
||
namespace {
|
||
|
||
TEST(Clock, ClockMonotonicNanoseconds) {
|
||
uint64_t start = ClockMonotonicNanoseconds();
|
||
EXPECT_GT(start, 0u);
|
||
|
||
uint64_t now = start;
|
||
for (size_t iteration = 0; iteration < 10; ++iteration) {
|
||
uint64_t last = now;
|
||
now = ClockMonotonicNanoseconds();
|
||
|
||
// Use EXPECT_GE instead of EXPECT_GT, because there are no guarantees about
|
||
// the clock’s resolution.
|
||
EXPECT_GE(now, last);
|
||
}
|
||
|
||
#if !defined(OS_WIN) // No SleepNanoseconds implemented on Windows.
|
||
// SleepNanoseconds() should sleep for at least the value of the clock’s
|
||
// resolution, so the clock’s value should definitely increase after a sleep.
|
||
// EXPECT_GT can be used instead of EXPECT_GE after the sleep.
|
||
SleepNanoseconds(1);
|
||
now = ClockMonotonicNanoseconds();
|
||
EXPECT_GT(now, start);
|
||
#endif // OS_WIN
|
||
}
|
||
|
||
#if !defined(OS_WIN) // No SleepNanoseconds implemented on Windows.
|
||
|
||
void TestSleepNanoseconds(uint64_t nanoseconds) {
|
||
uint64_t start = ClockMonotonicNanoseconds();
|
||
|
||
SleepNanoseconds(nanoseconds);
|
||
|
||
uint64_t end = ClockMonotonicNanoseconds();
|
||
uint64_t diff = end - start;
|
||
|
||
// |nanoseconds| is the lower bound for the actual amount of time spent
|
||
// sleeping.
|
||
EXPECT_GE(diff, nanoseconds);
|
||
|
||
// It’s difficult to set an upper bound for the time spent sleeping, and
|
||
// attempting to do so results in a flaky test.
|
||
}
|
||
|
||
TEST(Clock, SleepNanoseconds) {
|
||
static constexpr uint64_t kTestData[] = {
|
||
0,
|
||
1,
|
||
static_cast<uint64_t>(1E3), // 1 microsecond
|
||
static_cast<uint64_t>(1E4), // 10 microseconds
|
||
static_cast<uint64_t>(1E5), // 100 microseconds
|
||
static_cast<uint64_t>(1E6), // 1 millisecond
|
||
static_cast<uint64_t>(1E7), // 10 milliseconds
|
||
static_cast<uint64_t>(2E7), // 20 milliseconds
|
||
static_cast<uint64_t>(5E7), // 50 milliseconds
|
||
};
|
||
|
||
for (size_t index = 0; index < base::size(kTestData); ++index) {
|
||
const uint64_t nanoseconds = kTestData[index];
|
||
SCOPED_TRACE(base::StringPrintf(
|
||
"index %zu, nanoseconds %" PRIu64, index, nanoseconds));
|
||
|
||
TestSleepNanoseconds(nanoseconds);
|
||
}
|
||
}
|
||
|
||
#endif // OS_WIN
|
||
|
||
} // namespace
|
||
} // namespace test
|
||
} // namespace crashpad
|