mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-09 14:06:33 +00:00
fdc1883a13
Flaking like: [ RUN ] ProcessReaderFuchsia.ChildThreads [22244:22258:20181109,001621.809627:ERROR scoped_task_suspend.cc:44] thread failed to suspend [22244:22258:20181109,001621.810893:WARNING process_reader_fuchsia.cc:283] zx_thread_read_state(ZX_THREAD_STATE_GENERAL_REGS): ZX_ERR_BAD_STATE (-20) [22244:22258:20181109,001621.810937:WARNING process_reader_fuchsia.cc:295] zx_thread_read_state(ZX_THREAD_STATE_VECTOR_REGS): ZX_ERR_BAD_STATE (-20) ../../third_party/crashpad/snapshot/fuchsia/process_reader_fuchsia_test.cc:161: Failure Expected: (threads[i].stack_regions.size()) > (0u), actual: 0 vs 0 [ FAILED ] ProcessReaderFuchsia.ChildThreads (2487 ms) ScopedTaskSuspend appears to try relatively hard to suspend, and without retrying indefinitely it's not clear how to do a better job. Retrying forever isn't suitable for production code though, where it would cause the crash reporter to hang. Bug: fuchsia:US-553 Change-Id: Ie233d2f5578cb8c35ce47207df4f1f8d2e1152f1 Reviewed-on: https://chromium-review.googlesource.com/c/1328022 Reviewed-by: Francois Rousseau <frousseau@google.com> Commit-Queue: Scott Graham <scottmg@chromium.org>