mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-27 15:32:10 +08:00
50ed179e9a
Use BUILDFLAG(IS_*) instead of defined(OS_*).
This was generated mostly mechnically by performing the following steps:
- sed -i '' -E -e 's/defined\(OS_/BUILDFLAG(IS_/g' \
-e 's%([ !])OS_([A-Z]+)%\1BUILDFLAG(IS_\2)%g' \
$(git grep -l 'OS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- sed -i '' -e 's/#ifdef BUILDFLAG(/#if BUILDFLAG(/' \
$(git grep -l '#ifdef BUILDFLAG('
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- gsed -i -z -E -e \
's%(.*)#include "%\1#include "build/buildflag.h"\n#include "%' \
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- Spot checks to move #include "build/buildflag.h" to the correct parts
of files.
- sed -i '' -E -e \
's%^(#include "build/buildflag.h")$%#include "build/build_config.h"\n\1%' \
$(grep -L '^#include "build/build_config.h"$'
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'))
- Add “clang-format off” around tool usage messages.
- git cl format
- Update mini_chromium to 85ba51f98278 (intermediate step).
TESTING ONLY).
- for f in $(git grep -l '^#include "build/buildflag.h"$'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'); do \
grep -v '^#include "build/buildflag.h"$' "${f}" > /tmp/z; \
cp /tmp/z "${f}"; done
- git cl format
- Update mini_chromium to 735143774c5f (intermediate step).
- Update mini_chromium to f41420eb45fa (as checked in).
- Update mini_chromium to 6e2f204b4ae1 (as checked in).
For ease of review and inspection, each of these steps is uploaded as a
new patch set in a review series.
This includes an update of mini_chromium to 6e2f204b4ae1:
f41420eb45fa Use BUILDFLAG for OS checking
6e2f204b4ae1 Include what you use: string_util.h uses build_config.h
Bug: chromium:1234043
Change-Id: Ieef86186f094c64e59b853729737e36982f8cf69
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3400258
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
88 lines
2.5 KiB
C++
88 lines
2.5 KiB
C++
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef CRASHPAD_TEST_SCOPED_MODULE_HANDLE_H_
|
|
#define CRASHPAD_TEST_SCOPED_MODULE_HANDLE_H_
|
|
|
|
#include "build/build_config.h"
|
|
|
|
#if BUILDFLAG(IS_POSIX)
|
|
#include <dlfcn.h>
|
|
#elif BUILDFLAG(IS_WIN)
|
|
#include <windows.h>
|
|
#endif
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
|
|
//! \brief Maintains ownership of a loadable module handle, releasing it as
|
|
//! appropriate on destruction.
|
|
class ScopedModuleHandle {
|
|
private:
|
|
class Impl {
|
|
public:
|
|
Impl() = delete;
|
|
Impl(const Impl&) = delete;
|
|
Impl& operator=(const Impl&) = delete;
|
|
|
|
#if BUILDFLAG(IS_POSIX)
|
|
using ModuleHandle = void*;
|
|
|
|
static void* LookUpSymbol(ModuleHandle handle, const char* symbol_name) {
|
|
return dlsym(handle, symbol_name);
|
|
}
|
|
#elif BUILDFLAG(IS_WIN)
|
|
using ModuleHandle = HMODULE;
|
|
|
|
static void* LookUpSymbol(ModuleHandle handle, const char* symbol_name) {
|
|
return reinterpret_cast<void*>(GetProcAddress(handle, symbol_name));
|
|
}
|
|
#endif
|
|
|
|
static void Close(ModuleHandle handle);
|
|
};
|
|
|
|
public:
|
|
using ModuleHandle = Impl::ModuleHandle;
|
|
|
|
explicit ScopedModuleHandle(ModuleHandle handle);
|
|
ScopedModuleHandle(ScopedModuleHandle&& handle);
|
|
|
|
ScopedModuleHandle(const ScopedModuleHandle&) = delete;
|
|
ScopedModuleHandle& operator=(const ScopedModuleHandle&) = delete;
|
|
|
|
~ScopedModuleHandle();
|
|
|
|
//! \return The module handle being managed.
|
|
ModuleHandle get() const { return handle_; }
|
|
|
|
//! \return `true` if this object manages a valid loadable module handle.
|
|
bool valid() const { return handle_ != nullptr; }
|
|
|
|
//! \return The value of the symbol named by \a symbol_name, or `nullptr` on
|
|
//! failure.
|
|
template <typename T>
|
|
T LookUpSymbol(const char* symbol_name) const {
|
|
return reinterpret_cast<T>(Impl::LookUpSymbol(handle_, symbol_name));
|
|
}
|
|
|
|
private:
|
|
ModuleHandle handle_;
|
|
};
|
|
|
|
} // namespace test
|
|
} // namespace crashpad
|
|
|
|
#endif // CRASHPAD_TEST_SCOPED_MODULE_HANDLE_H_
|