mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-27 15:32:10 +08:00
50ed179e9a
Use BUILDFLAG(IS_*) instead of defined(OS_*).
This was generated mostly mechnically by performing the following steps:
- sed -i '' -E -e 's/defined\(OS_/BUILDFLAG(IS_/g' \
-e 's%([ !])OS_([A-Z]+)%\1BUILDFLAG(IS_\2)%g' \
$(git grep -l 'OS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- sed -i '' -e 's/#ifdef BUILDFLAG(/#if BUILDFLAG(/' \
$(git grep -l '#ifdef BUILDFLAG('
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- gsed -i -z -E -e \
's%(.*)#include "%\1#include "build/buildflag.h"\n#include "%' \
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- Spot checks to move #include "build/buildflag.h" to the correct parts
of files.
- sed -i '' -E -e \
's%^(#include "build/buildflag.h")$%#include "build/build_config.h"\n\1%' \
$(grep -L '^#include "build/build_config.h"$'
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'))
- Add “clang-format off” around tool usage messages.
- git cl format
- Update mini_chromium to 85ba51f98278 (intermediate step).
TESTING ONLY).
- for f in $(git grep -l '^#include "build/buildflag.h"$'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'); do \
grep -v '^#include "build/buildflag.h"$' "${f}" > /tmp/z; \
cp /tmp/z "${f}"; done
- git cl format
- Update mini_chromium to 735143774c5f (intermediate step).
- Update mini_chromium to f41420eb45fa (as checked in).
- Update mini_chromium to 6e2f204b4ae1 (as checked in).
For ease of review and inspection, each of these steps is uploaded as a
new patch set in a review series.
This includes an update of mini_chromium to 6e2f204b4ae1:
f41420eb45fa Use BUILDFLAG for OS checking
6e2f204b4ae1 Include what you use: string_util.h uses build_config.h
Bug: chromium:1234043
Change-Id: Ieef86186f094c64e59b853729737e36982f8cf69
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3400258
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
83 lines
3.2 KiB
C++
83 lines
3.2 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#ifndef CRASHPAD_TEST_ERRORS_H_
|
||
#define CRASHPAD_TEST_ERRORS_H_
|
||
|
||
#include <string>
|
||
|
||
#include "build/build_config.h"
|
||
|
||
namespace crashpad {
|
||
namespace test {
|
||
|
||
// These functions format messages in a similar way to the PLOG and PCHECK
|
||
// family of logging macros in base/logging.h. They exist to interoperate with
|
||
// Google Test assertions, which don’t interoperate with logging but can be
|
||
// streamed to.
|
||
//
|
||
// Where non-test code could do:
|
||
// PCHECK(rv == 0) << "close";
|
||
// Google Test-based test code can do:
|
||
// EXPECT_EQ(rv, 0) << ErrnoMessage("close");
|
||
|
||
//! \brief Formats an error message using an `errno` value.
|
||
//!
|
||
//! The returned string will combine the \a base string, if supplied, with a
|
||
//! textual and numeric description of the error.
|
||
//!
|
||
//! The message is formatted using `strerror()`. \a err may be `0` or outside of
|
||
//! the range of known error codes, and the message returned will contain the
|
||
//! string that `strerror()` uses in these cases.
|
||
//!
|
||
//! \param[in] err The error code, usable as an `errno` value.
|
||
//! \param[in] base A string to prepend to the error description.
|
||
//!
|
||
//! \return A string of the format `"Operation not permitted (1)"` if \a err has
|
||
//! the value `EPERM` on a system where this is defined to be `1`. If \a
|
||
//! base is not empty, it will be prepended to this string, separated by a
|
||
//! colon.
|
||
std::string ErrnoMessage(int err, const std::string& base = std::string());
|
||
|
||
//! \brief Formats an error message using `errno`.
|
||
//!
|
||
//! The returned string will combine the \a base string, if supplied, with a
|
||
//! textual and numeric description of the error.
|
||
//!
|
||
//! The message is formatted using `strerror()`. `errno` may be `0` or outside
|
||
//! of the range of known error codes, and the message returned will contain the
|
||
//! string that `strerror()` uses in these cases.
|
||
//!
|
||
//! \param[in] base A string to prepend to the error description.
|
||
//!
|
||
//! \return A string of the format `"Operation not permitted (1)"` if `errno`
|
||
//! has the value `EPERM` on a system where this is defined to be `1`. If
|
||
//! \a base is not empty, it will be prepended to this string, separated by
|
||
//! a colon.
|
||
std::string ErrnoMessage(const std::string& base = std::string());
|
||
|
||
#if BUILDFLAG(IS_WIN) || DOXYGEN
|
||
//! \brief Formats an error message using `GetLastError()`.
|
||
//!
|
||
//! The returned string will combine the \a base string, if supplied, with a
|
||
//! textual and numeric description of the error. The format is the same as the
|
||
//! `PLOG()` formatting in base.
|
||
std::string ErrorMessage(const std::string& base = std::string());
|
||
#endif
|
||
|
||
} // namespace test
|
||
} // namespace crashpad
|
||
|
||
#endif // CRASHPAD_TEST_ERRORS_H_
|