Mark Mentovai 4688351623 “Promote” test::Paths::Executable() to Paths::Executable() ...

This supports the “double handler” or “double handler with low
probability” models from https://crashpad.chromium.org/bug/143.

For crashpad_handler to be become its own client, it needs access to its
own executable path to pass to CrashpadClient::StartHandler(). This was
formerly available in the test-only test::Paths::Executable(). Bring
that function’s implementation to the non-test Paths::Executable() in
util/misc, and rename test::Paths to test::TestPaths to avoid future
confusion.

test::TestPaths must still be used to access TestDataRoot(), which does
not make any sense to non-test code.

test::TestPaths::Executable() is retained for use by tests, which most
likely prefer the fatal semantics of that function. Paths::Executable()
is not fatal because for the purposes of implementing the double
handler, a failure to locate the executable path (which may happen on
some systems in deeply-nested directory hierarchies) shouldn’t cause the
initial crashpad_handler to abort, even if it does prevent a second
crashpad_handler from being started.

Bug: crashpad:143
Test: crashpad_util_test Paths.*, crashpad_test_test TestPaths.*
Change-Id: I9f75bf61839ce51e33c9f7c0d7031cebead6a156
Reviewed-on: https://chromium-review.googlesource.com/466346
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>

2017-04-03 18:58:01 +00:00

..

mac

Convert from scoped_ptr to std::unique_ptr

2016-04-25 19:16:26 +00:00

win

“Promote” test::Paths::Executable() to Paths::Executable()

2017-04-03 18:58:01 +00:00

errors.cc

Roll DEPS for mini_chromium for updates to base/posix/safe_strerror

2015-06-11 20:25:49 -04:00

errors.h

test: Move util/test to its own top-level directory, test.

2015-03-31 17:44:14 -04:00

file.cc

Use base/macros.h instead of base/basictypes.h

2016-01-06 12:22:50 -05:00

file.h

Add FileWriteMode::kCreateOrFail

2015-10-07 08:20:55 -04:00

gmock_main.cc

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00

gtest_death_check.h

test: Move util/test to its own top-level directory, test.

2015-03-31 17:44:14 -04:00

gtest_main.cc

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00

hex_string_test.cc

Centrally define CPUContextX86::Fsave and fsave↔︎fxsave conversions

2017-02-16 18:26:13 +00:00

hex_string.cc

Centrally define CPUContextX86::Fsave and fsave↔︎fxsave conversions

2017-02-16 18:26:13 +00:00

hex_string.h

Centrally define CPUContextX86::Fsave and fsave↔︎fxsave conversions

2017-02-16 18:26:13 +00:00

main_arguments_test.cc

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00

main_arguments.cc

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00

main_arguments.h

test: Compare ProcessInfo::Arguments() to main()’s argc/argv on POSIX

2017-03-20 17:05:30 +00:00

multiprocess_exec_posix.cc

Port the test library and crashpad_test_test to Linux/Android

2016-10-31 19:30:24 +00:00

multiprocess_exec_test_child.cc

Port the test library and crashpad_test_test to Linux/Android

2016-10-31 19:30:24 +00:00

multiprocess_exec_test.cc

“Promote” test::Paths::Executable() to Paths::Executable()

2017-04-03 18:58:01 +00:00

multiprocess_exec_win.cc

Use base/macros.h instead of base/basictypes.h

2016-01-06 12:22:50 -05:00

multiprocess_exec.h

Use base/macros.h instead of base/basictypes.h

2016-01-06 12:22:50 -05:00

multiprocess_posix_test.cc

Make file_io reads more rational and predictable

2017-03-16 20:07:43 +00:00

multiprocess_posix.cc

posix: Correctly show the expected exit status in multiprocess tests

2016-06-20 21:08:08 +00:00

multiprocess.h

Use base/macros.h instead of base/basictypes.h

2016-01-06 12:22:50 -05:00

scoped_temp_dir_posix.cc

Port the test library and crashpad_test_test to Linux/Android

2016-10-31 19:30:24 +00:00

scoped_temp_dir_test.cc

Add FileWriteMode::kCreateOrFail

2015-10-07 08:20:55 -04:00

scoped_temp_dir_win.cc

Add RandomString() and its test, and use it everywhere it makes sense

2015-11-16 13:39:01 -05:00

scoped_temp_dir.cc

test: Move util/test to its own top-level directory, test.

2015-03-31 17:44:14 -04:00

scoped_temp_dir.h

Use base/macros.h instead of base/basictypes.h

2016-01-06 12:22:50 -05:00

test_paths_test_data_root.txt

“Promote” test::Paths::Executable() to Paths::Executable()

2017-04-03 18:58:01 +00:00

test_paths_test.cc

“Promote” test::Paths::Executable() to Paths::Executable()

2017-04-03 18:58:01 +00:00

test_paths.cc

“Promote” test::Paths::Executable() to Paths::Executable()

2017-04-03 18:58:01 +00:00

test_paths.h

“Promote” test::Paths::Executable() to Paths::Executable()

2017-04-03 18:58:01 +00:00

test_test.gyp

“Promote” test::Paths::Executable() to Paths::Executable()

2017-04-03 18:58:01 +00:00

test.gyp

“Promote” test::Paths::Executable() to Paths::Executable()

2017-04-03 18:58:01 +00:00