mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-27 07:14:10 +08:00
3030ae5417
After the avoidance of abspath(), automatic regeneration of ninja files was broken following a test run. The problem is that the --runtime-deps-list-file argument gets saved into the regeneration rule, but it's relative to the cwd. The cwd is CRASHPAD_DIR on the first run, but the binary_dir on regenerations, so either way it doesn't work (this should probably fixed in either GN or ninja). We could abspath the path the runtime deps targets file to avoid this. However, it's a bit cluttery to have that --runtime-deps-list-file in the regeneration rule anyway, when really it's only required to extract runtime deps at test-running time. (Also, if you happened to delete only targets.txt from the out dir, the regeneration would mysteriously fail.) So since generation only takes tens of milliseconds, the best thing to do is just remove it from the regeneration rule by re-running gn gen without the flag after we've extracted the .runtime_deps to prepare for the run. Bug: crashpad:196, chromium:814816 Change-Id: I009851d8b821fef5c953d463ba9c4880e5cc082a Reviewed-on: https://chromium-review.googlesource.com/929887 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>