mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00

Go to file

Mark Mentovai f83530bf9a GCC fix: Don’t use arraysize() on packed structs

While compiling, for example, minidump_exception_writer.cc:

In file included from ../../minidump/minidump_exception_writer.h:26:0,
                 from ../../minidump/minidump_exception_writer.cc:15:
../../minidump/minidump_exception_writer.cc: In member function ‘void crashpad::MinidumpExceptionWriter::SetExceptionInformation(const std::vector<long unsigned int>&)’:
../../minidump/minidump_exception_writer.cc:67:44: error: cannot bind packed field ‘((crashpad::MinidumpExceptionWriter*)this)->crashpad::MinidumpExceptionWriter::exception_.MINIDUMP_EXCEPTION_STREAM::ExceptionRecord.MINIDUMP_EXCEPTION::ExceptionInformation’ to ‘long unsigned int (&)[15]’
       arraysize(exception_.ExceptionRecord.ExceptionInformation);
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~^
../../third_party/mini_chromium/mini_chromium/base/macros.h:41:50: note: in definition of macro ‘arraysize’
 #define arraysize(array) (sizeof(ArraySizeHelper(array)))

Tested with:
 - GCC 4.9 from NDK r13 targeting arm with SDK 16
 - GCC 4.9 from NDK r13 targeting arm64 with SDK 21
 - GCC 6.2 targeting x86_64

BUG=crashpad:30

Change-Id: I63963b277a309b4715148215f51902c33ba13b5a
Reviewed-on: https://chromium-review.googlesource.com/409694
Reviewed-by: Scott Graham <scottmg@chromium.org>

2016-11-11 17:38:01 +00:00

build

GCC fix: Disable -Wmultichar warning throughout Crashpad

2016-11-11 17:35:25 +00:00

client

doc: Fix all Doxygen warnings, cleaning up some generated documentation

2016-11-08 19:24:05 +00:00

compat

Provide backup #defines for things introduced in SDK 10.0.10240.0

2016-11-10 01:50:17 +00:00

doc

GCC fix: Disable -Wmultichar warning throughout Crashpad