mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-31 01:43:03 +08:00
f735d050c4
With this change, it is possible to build crashpad_util on Linux. I
built with clang 3.8.1 and GCC 6.2.0.
- For per-OS “exception code” metrics, Android and Linux are broken out
distinctly.
- Because Linux provides no standard UUID generator, base::RandBytes()
is used to generate random UUIDs for the InitializeWithNew() form.
- Multiple fixes for CloseMultipleNowOrOnExec():
- readdir_r() is deprecated in glibc 2.24. Use readdir() on Linux.
- Linux does not have OPEN_MAX. Use the fs.nr_open sysctl (via
/proc/sys) to determine the maximum (currently-configured)
possible number of file descriptors per process.
- Use the {CTL_KERN, KERN_MAXFILESPERPROC} sysctl on Mac to
determine the maximum (currently-configured) possible number of
file descriptors per process. This is an improvement over using
OPEN_MAX, which is still consulted.
- ThreadLogMessages’ use of DCHECK_EQ() needs an address-of operator on
function pointers to avoid confusing GCC.
One problem remains:
- util/misc/pdb_structures.h produces -Wmultichar errors. -Wmultichar
is enabled by default with GCC (but not clang). It is impossible to
disable this warning with #pragma GCC diagnostic ignored. See
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53431
This has not been tested beyond building the crashpad_util target.
BUG=crashpad:30
Change-Id: I02e7a05da512ca312806d825b3fc9b2c5bf1a990
Reviewed-on: https://chromium-review.googlesource.com/404009
Reviewed-by: Robert Sesek <rsesek@chromium.org>
102 lines
3.2 KiB
C++
102 lines
3.2 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#include "util/thread/thread_log_messages.h"
|
||
|
||
#include <sys/types.h>
|
||
|
||
#include "base/lazy_instance.h"
|
||
#include "base/logging.h"
|
||
#include "base/threading/thread_local_storage.h"
|
||
|
||
namespace crashpad {
|
||
|
||
namespace {
|
||
|
||
// While an object of this class exists, it will be set as the log message
|
||
// handler. A thread may register its thread-specific log message list to
|
||
// receive messages produced just on that thread.
|
||
//
|
||
// Only one object of this class may exist in the program at a time. There must
|
||
// not be any log message handler in effect when it is created, and nothing else
|
||
// can be set as a log message handler while an object of this class exists.
|
||
//
|
||
// Practically, the only object of this class that might exist is managed by the
|
||
// g_master lazy instance, which will create it upon first use.
|
||
class ThreadLogMessagesMaster {
|
||
public:
|
||
ThreadLogMessagesMaster() {
|
||
DCHECK(!tls_.initialized());
|
||
tls_.Initialize(nullptr);
|
||
DCHECK(tls_.initialized());
|
||
|
||
DCHECK(!logging::GetLogMessageHandler());
|
||
logging::SetLogMessageHandler(LogMessageHandler);
|
||
}
|
||
|
||
~ThreadLogMessagesMaster() {
|
||
DCHECK_EQ(logging::GetLogMessageHandler(), &LogMessageHandler);
|
||
logging::SetLogMessageHandler(nullptr);
|
||
|
||
tls_.Free();
|
||
}
|
||
|
||
void SetThreadMessageList(std::vector<std::string>* message_list) {
|
||
DCHECK_EQ(logging::GetLogMessageHandler(), &LogMessageHandler);
|
||
DCHECK_NE(tls_.Get() != nullptr, message_list != nullptr);
|
||
tls_.Set(message_list);
|
||
}
|
||
|
||
private:
|
||
static bool LogMessageHandler(logging::LogSeverity severity,
|
||
const char* file_path,
|
||
int line,
|
||
size_t message_start,
|
||
const std::string& string) {
|
||
std::vector<std::string>* log_messages =
|
||
reinterpret_cast<std::vector<std::string>*>(tls_.Get());
|
||
if (log_messages) {
|
||
log_messages->push_back(string);
|
||
}
|
||
|
||
// Don’t consume the message. Allow it to be logged as if nothing was set as
|
||
// the log message handler.
|
||
return false;
|
||
}
|
||
|
||
static base::ThreadLocalStorage::StaticSlot tls_;
|
||
|
||
DISALLOW_COPY_AND_ASSIGN(ThreadLogMessagesMaster);
|
||
};
|
||
|
||
// static
|
||
base::ThreadLocalStorage::StaticSlot ThreadLogMessagesMaster::tls_
|
||
= TLS_INITIALIZER;
|
||
|
||
base::LazyInstance<ThreadLogMessagesMaster>::Leaky g_master =
|
||
LAZY_INSTANCE_INITIALIZER;
|
||
|
||
} // namespace
|
||
|
||
ThreadLogMessages::ThreadLogMessages()
|
||
: log_messages_() {
|
||
g_master.Get().SetThreadMessageList(&log_messages_);
|
||
}
|
||
|
||
ThreadLogMessages::~ThreadLogMessages() {
|
||
g_master.Get().SetThreadMessageList(nullptr);
|
||
}
|
||
|
||
} // namespace crashpad
|