mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-09 22:26:06 +00:00
f5c4273d4f
This log spam from end_to_end_test.py indicated that GetFileVersionInfo() was being called three times per module: [3076:3424:20151123,102817.290:WARNING module_version.cc:29] GetFileVersionInfoSize: ...\crashpad\out\Release_x64\crashy_program.exe: The specified resource type cannot be found in the image file. (1813) [3076:3424:20151123,102817.291:WARNING module_version.cc:29] GetFileVersionInfoSize: ...\crashpad\out\Release_x64\crashy_program.exe: The specified resource type cannot be found in the image file. (1813) [3076:3424:20151123,102817.291:WARNING module_version.cc:29] GetFileVersionInfoSize: ...\crashpad\out\Release_x64\crashy_program.exe: The specified resource type cannot be found in the image file. (1813) This is unnecessary. It only needs to be called once. We may want to avoid logging in GetModuleVersionAndType() when GetLastError() is ERROR_RESOURCE_TYPE_NOT_FOUND. R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1472963002 .