mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-30 01:06:56 +08:00
9b6c69cbb5
Follows https://chromium-review.googlesource.com/c/374019/. Causes MinidumpMemoryListWriter to merge all overlapping ranges before writing the MINIDUMP_MEMORY_LIST. This is: 1) Necessary for the Google internal crash processor, which in some cases attempts to read the raw memory (displaying ASAN red zones), and aborts if there are any overlapping ranges in the minidump on load; 2) Necessary for new-ish versions of windbg (see bug 216 below). It is believed that this is a change in behavior in the tool that made dumps with overlapping ranges unreadable; 3) More efficient. The .dmp for crashy_program goes from 306K to 140K with this enabled. In Chrome minidumps where set_gather_indirectly_referenced_memory() is used (in practice this means Chrome Windows Beta, Dev, and Canary), the savings are expected to be substantial. Bug: crashpad:61, chromium:638370, crashpad:216 Change-Id: I969e1a52da555ceba59a727d933bfeef6787c7a5 Reviewed-on: https://chromium-review.googlesource.com/374539 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
76 lines
2.4 KiB
C++
76 lines
2.4 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef CRASHPAD_SNAPSHOT_WIN_MEMORY_SNAPSHOT_WIN_H_
|
|
#define CRASHPAD_SNAPSHOT_WIN_MEMORY_SNAPSHOT_WIN_H_
|
|
|
|
#include <stdint.h>
|
|
#include <sys/types.h>
|
|
|
|
#include "base/macros.h"
|
|
#include "snapshot/memory_snapshot.h"
|
|
#include "snapshot/win/process_reader_win.h"
|
|
#include "util/misc/initialization_state_dcheck.h"
|
|
|
|
namespace crashpad {
|
|
namespace internal {
|
|
|
|
//! \brief A MemorySnapshot of a memory region in a process on the running
|
|
//! system, when the system runs Windows.
|
|
class MemorySnapshotWin final : public MemorySnapshot {
|
|
public:
|
|
MemorySnapshotWin();
|
|
~MemorySnapshotWin() override;
|
|
|
|
//! \brief Initializes the object.
|
|
//!
|
|
//! Memory is read lazily. No attempt is made to read the memory snapshot data
|
|
//! until Read() is called, and the memory snapshot data is discared when
|
|
//! Read() returns.
|
|
//!
|
|
//! \param[in] process_reader A reader for the process being snapshotted.
|
|
//! \param[in] address The base address of the memory region to snapshot, in
|
|
//! the snapshot process' address space.
|
|
//! \param[in] size The size of the memory region to snapshot.
|
|
void Initialize(ProcessReaderWin* process_reader,
|
|
uint64_t address,
|
|
uint64_t size);
|
|
|
|
// MemorySnapshot:
|
|
|
|
uint64_t Address() const override;
|
|
size_t Size() const override;
|
|
bool Read(Delegate* delegate) const override;
|
|
const MemorySnapshot* MergeWithOtherSnapshot(
|
|
const MemorySnapshot* other) const override;
|
|
|
|
private:
|
|
template <class T>
|
|
friend const MemorySnapshot* MergeWithOtherSnapshotImpl(
|
|
const T* self,
|
|
const MemorySnapshot* other);
|
|
|
|
ProcessReaderWin* process_reader_; // weak
|
|
uint64_t address_;
|
|
size_t size_;
|
|
InitializationStateDcheck initialized_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(MemorySnapshotWin);
|
|
};
|
|
|
|
} // namespace internal
|
|
} // namespace crashpad
|
|
|
|
#endif // CRASHPAD_SNAPSHOT_WIN_MEMORY_SNAPSHOT_WIN_H_
|