mirror of https://github.com/chromium/crashpad.git synced 2025-01-14 01:08:01 +08:00

Go to file

Mark Mentovai dd85381a32 GCC fix: Disable -Wmultichar warning throughout Crashpad

-Wmultichar is enabled by default with GCC (but not clang). It is
impossible to disable this warning with #pragma GCC diagnostic ignored.
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53431

While compiling, for example, minidump_file_writer.cc:

In file included from ../../minidump/minidump_extensions.h:25:0,
                 from ../../minidump/minidump_file_writer.h:27,
                 from ../../minidump/minidump_file_writer.cc:15:
../../util/misc/pdb_structures.h:45:38: error: multi-character character constan
t [-Werror=multichar]
   static const uint32_t kSignature = '01BN';
                                      ^~~~~~
../../util/misc/pdb_structures.h:106:38: error: multi-character character consta
nt [-Werror=multichar]
   static const uint32_t kSignature = 'SDSR';
                                      ^~~~~~
../../minidump/minidump_file_writer.cc:190:23: error: multi-character character
constant [-Werror=multichar]
   header_.Signature = MINIDUMP_SIGNATURE;
                       ^~~~~~~~~~~~~~~~~~

doc/developing.md is also updated to provide GCC build instructions for
Android.

Tested with:
 - GCC 4.9 from NDK r13 targeting arm with SDK 16
 - GCC 4.9 from NDK r13 targeting arm64 with SDK 21
 - GCC 6.2 targeting x86_64

BUG=crashpad:30

Change-Id: I9e7993761f5461281c9f4d8b4c56e8407e2c5b47
Reviewed-on: https://chromium-review.googlesource.com/409776
Reviewed-by: Robert Sesek <rsesek@chromium.org>

2016-11-11 17:35:25 +00:00

build

GCC fix: Disable -Wmultichar warning throughout Crashpad

2016-11-11 17:35:25 +00:00

client

doc: Fix all Doxygen warnings, cleaning up some generated documentation

2016-11-08 19:24:05 +00:00

compat

Provide backup #defines for things introduced in SDK 10.0.10240.0

2016-11-10 01:50:17 +00:00

doc

GCC fix: Disable -Wmultichar warning throughout Crashpad