mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-10 06:36:02 +00:00
50ed179e9a
Use BUILDFLAG(IS_*) instead of defined(OS_*).
This was generated mostly mechnically by performing the following steps:
- sed -i '' -E -e 's/defined\(OS_/BUILDFLAG(IS_/g' \
-e 's%([ !])OS_([A-Z]+)%\1BUILDFLAG(IS_\2)%g' \
$(git grep -l 'OS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- sed -i '' -e 's/#ifdef BUILDFLAG(/#if BUILDFLAG(/' \
$(git grep -l '#ifdef BUILDFLAG('
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- gsed -i -z -E -e \
's%(.*)#include "%\1#include "build/buildflag.h"\n#include "%' \
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm')
- Spot checks to move #include "build/buildflag.h" to the correct parts
of files.
- sed -i '' -E -e \
's%^(#include "build/buildflag.h")$%#include "build/build_config.h"\n\1%' \
$(grep -L '^#include "build/build_config.h"$'
$(git grep -l 'BUILDFLAG(IS_'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'))
- Add “clang-format off” around tool usage messages.
- git cl format
- Update mini_chromium to 85ba51f98278 (intermediate step).
TESTING ONLY).
- for f in $(git grep -l '^#include "build/buildflag.h"$'
'**/*.c' '**/*.cc' '**/*.h' '**/*.m' '**/*.mm'); do \
grep -v '^#include "build/buildflag.h"$' "${f}" > /tmp/z; \
cp /tmp/z "${f}"; done
- git cl format
- Update mini_chromium to 735143774c5f (intermediate step).
- Update mini_chromium to f41420eb45fa (as checked in).
- Update mini_chromium to 6e2f204b4ae1 (as checked in).
For ease of review and inspection, each of these steps is uploaded as a
new patch set in a review series.
This includes an update of mini_chromium to 6e2f204b4ae1:
f41420eb45fa Use BUILDFLAG for OS checking
6e2f204b4ae1 Include what you use: string_util.h uses build_config.h
Bug: chromium:1234043
Change-Id: Ieef86186f094c64e59b853729737e36982f8cf69
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3400258
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
100 lines
3.0 KiB
C++
100 lines
3.0 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#include "util/misc/clock.h"
|
||
|
||
#include <sys/types.h>
|
||
|
||
#include <algorithm>
|
||
|
||
#include "base/cxx17_backports.h"
|
||
#include "base/format_macros.h"
|
||
#include "base/strings/stringprintf.h"
|
||
#include "build/build_config.h"
|
||
#include "gtest/gtest.h"
|
||
|
||
namespace crashpad {
|
||
namespace test {
|
||
namespace {
|
||
|
||
TEST(Clock, ClockMonotonicNanoseconds) {
|
||
uint64_t start = ClockMonotonicNanoseconds();
|
||
EXPECT_GT(start, 0u);
|
||
|
||
uint64_t now = start;
|
||
for (size_t iteration = 0; iteration < 10; ++iteration) {
|
||
uint64_t last = now;
|
||
now = ClockMonotonicNanoseconds();
|
||
|
||
// Use EXPECT_GE instead of EXPECT_GT, because there are no guarantees about
|
||
// the clock’s resolution.
|
||
EXPECT_GE(now, last);
|
||
}
|
||
|
||
#if !BUILDFLAG(IS_WIN) // No SleepNanoseconds implemented on Windows.
|
||
// SleepNanoseconds() should sleep for at least the value of the clock’s
|
||
// resolution, so the clock’s value should definitely increase after a sleep.
|
||
// EXPECT_GT can be used instead of EXPECT_GE after the sleep.
|
||
SleepNanoseconds(1);
|
||
now = ClockMonotonicNanoseconds();
|
||
EXPECT_GT(now, start);
|
||
#endif // BUILDFLAG(IS_WIN)
|
||
}
|
||
|
||
#if !BUILDFLAG(IS_WIN) // No SleepNanoseconds implemented on Windows.
|
||
|
||
void TestSleepNanoseconds(uint64_t nanoseconds) {
|
||
uint64_t start = ClockMonotonicNanoseconds();
|
||
|
||
SleepNanoseconds(nanoseconds);
|
||
|
||
uint64_t end = ClockMonotonicNanoseconds();
|
||
uint64_t diff = end - start;
|
||
|
||
// |nanoseconds| is the lower bound for the actual amount of time spent
|
||
// sleeping.
|
||
EXPECT_GE(diff, nanoseconds);
|
||
|
||
// It’s difficult to set an upper bound for the time spent sleeping, and
|
||
// attempting to do so results in a flaky test.
|
||
}
|
||
|
||
TEST(Clock, SleepNanoseconds) {
|
||
static constexpr uint64_t kTestData[] = {
|
||
0,
|
||
1,
|
||
static_cast<uint64_t>(1E3), // 1 microsecond
|
||
static_cast<uint64_t>(1E4), // 10 microseconds
|
||
static_cast<uint64_t>(1E5), // 100 microseconds
|
||
static_cast<uint64_t>(1E6), // 1 millisecond
|
||
static_cast<uint64_t>(1E7), // 10 milliseconds
|
||
static_cast<uint64_t>(2E7), // 20 milliseconds
|
||
static_cast<uint64_t>(5E7), // 50 milliseconds
|
||
};
|
||
|
||
for (size_t index = 0; index < base::size(kTestData); ++index) {
|
||
const uint64_t nanoseconds = kTestData[index];
|
||
SCOPED_TRACE(base::StringPrintf(
|
||
"index %zu, nanoseconds %" PRIu64, index, nanoseconds));
|
||
|
||
TestSleepNanoseconds(nanoseconds);
|
||
}
|
||
}
|
||
|
||
#endif // BUILDFLAG(IS_WIN)
|
||
|
||
} // namespace
|
||
} // namespace test
|
||
} // namespace crashpad
|