mirror of
https://github.com/chromium/crashpad.git
synced 2025-01-06 20:13:01 +08:00
3983b80ca2
file_io and the FileReader family had a few loose ends regarding big reads and writes. It’s not likely that we’ve experienced these conditions yet, but they’d be likely to appear in a potential future involving full memory dumps. This specifies the behavior with large reads and writes, consolidates some logic, and improves some interfaces. ReadFile() should always return without retrying after a short read, and in fact does return after short reads since 00b64427523b. It is straightforward to limit the maximum read size based on a parameter limitation of the underlying operation, or a limitation of the type used for FileOperationResult. In contrast, WriteFile() should always retry after a short write, including a write shortened because of a parameter limitation of the underlying operation, or a limitation of the type used for FileOperationResult. This allows its return value to be simplified to a “bool”. The platform-specific WriteFile() code has been moved to internal::NativeWriteFile(), and the platform-independent loop that retries following a short write has been refactored into internal::WriteAllInternal so that it can be used by a new test. The platform-agnostic ReadFileExactlyInternal() implementation has been refactored into internal::ReadExactlyInternal so that it can be used by a new test and by FileReaderInterface::ReadExactly(), which had a nearly identical implementation. Test: crashpad_util_test FileIO.ReadExactly_*:FileIO.WriteAll_*:FileReader.ReadExactly_* Change-Id: I487450322ab049c6f2acd4061ea814037cc9a864 Reviewed-on: https://chromium-review.googlesource.com/456824 Reviewed-by: Scott Graham <scottmg@chromium.org>
210 lines
5.9 KiB
C++
210 lines
5.9 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/file/file_io.h"
|
|
|
|
#include <fcntl.h>
|
|
#include <sys/file.h>
|
|
#include <sys/stat.h>
|
|
#include <unistd.h>
|
|
|
|
#include <algorithm>
|
|
#include <limits>
|
|
|
|
#include "base/files/file_path.h"
|
|
#include "base/logging.h"
|
|
#include "base/posix/eintr_wrapper.h"
|
|
|
|
namespace crashpad {
|
|
|
|
namespace {
|
|
|
|
struct ReadTraits {
|
|
using BufferType = void*;
|
|
static FileOperationResult Operate(int fd, BufferType buffer, size_t size) {
|
|
return read(fd, buffer, size);
|
|
}
|
|
};
|
|
|
|
struct WriteTraits {
|
|
using BufferType = const void*;
|
|
static FileOperationResult Operate(int fd, BufferType buffer, size_t size) {
|
|
return write(fd, buffer, size);
|
|
}
|
|
};
|
|
|
|
template <typename Traits>
|
|
FileOperationResult ReadOrWrite(int fd,
|
|
typename Traits::BufferType buffer,
|
|
size_t size) {
|
|
constexpr size_t kMaxReadWriteSize =
|
|
static_cast<size_t>(std::numeric_limits<ssize_t>::max());
|
|
const size_t requested_bytes = std::min(size, kMaxReadWriteSize);
|
|
|
|
FileOperationResult transacted_bytes =
|
|
HANDLE_EINTR(Traits::Operate(fd, buffer, requested_bytes));
|
|
if (transacted_bytes < 0) {
|
|
return -1;
|
|
}
|
|
|
|
DCHECK_LE(static_cast<size_t>(transacted_bytes), requested_bytes);
|
|
return transacted_bytes;
|
|
}
|
|
|
|
FileHandle OpenFileForOutput(int rdwr_or_wronly,
|
|
const base::FilePath& path,
|
|
FileWriteMode mode,
|
|
FilePermissions permissions) {
|
|
int flags = O_NOCTTY | O_CLOEXEC;
|
|
|
|
DCHECK(rdwr_or_wronly & (O_RDWR | O_WRONLY));
|
|
DCHECK_EQ(rdwr_or_wronly & ~(O_RDWR | O_WRONLY), 0);
|
|
flags |= rdwr_or_wronly;
|
|
|
|
switch (mode) {
|
|
case FileWriteMode::kReuseOrFail:
|
|
break;
|
|
case FileWriteMode::kReuseOrCreate:
|
|
flags |= O_CREAT;
|
|
break;
|
|
case FileWriteMode::kTruncateOrCreate:
|
|
flags |= O_CREAT | O_TRUNC;
|
|
break;
|
|
case FileWriteMode::kCreateOrFail:
|
|
flags |= O_CREAT | O_EXCL;
|
|
break;
|
|
}
|
|
|
|
return HANDLE_EINTR(
|
|
open(path.value().c_str(),
|
|
flags,
|
|
permissions == FilePermissions::kWorldReadable ? 0644 : 0600));
|
|
}
|
|
|
|
} // namespace
|
|
|
|
namespace internal {
|
|
|
|
const char kNativeReadFunctionName[] = "read";
|
|
const char kNativeWriteFunctionName[] = "write";
|
|
|
|
FileOperationResult NativeWriteFile(FileHandle file,
|
|
const void* buffer,
|
|
size_t size) {
|
|
return ReadOrWrite<WriteTraits>(file, buffer, size);
|
|
}
|
|
|
|
} // namespace internal
|
|
|
|
FileOperationResult ReadFile(FileHandle file, void* buffer, size_t size) {
|
|
return ReadOrWrite<ReadTraits>(file, buffer, size);
|
|
}
|
|
|
|
FileHandle OpenFileForRead(const base::FilePath& path) {
|
|
return HANDLE_EINTR(
|
|
open(path.value().c_str(), O_RDONLY | O_NOCTTY | O_CLOEXEC));
|
|
}
|
|
|
|
FileHandle OpenFileForWrite(const base::FilePath& path,
|
|
FileWriteMode mode,
|
|
FilePermissions permissions) {
|
|
return OpenFileForOutput(O_WRONLY, path, mode, permissions);
|
|
}
|
|
|
|
FileHandle OpenFileForReadAndWrite(const base::FilePath& path,
|
|
FileWriteMode mode,
|
|
FilePermissions permissions) {
|
|
return OpenFileForOutput(O_RDWR, path, mode, permissions);
|
|
}
|
|
|
|
FileHandle LoggingOpenFileForRead(const base::FilePath& path) {
|
|
FileHandle fd = OpenFileForRead(path);
|
|
PLOG_IF(ERROR, fd < 0) << "open " << path.value();
|
|
return fd;
|
|
}
|
|
|
|
FileHandle LoggingOpenFileForWrite(const base::FilePath& path,
|
|
FileWriteMode mode,
|
|
FilePermissions permissions) {
|
|
FileHandle fd = OpenFileForWrite(path, mode, permissions);
|
|
PLOG_IF(ERROR, fd < 0) << "open " << path.value();
|
|
return fd;
|
|
}
|
|
|
|
FileHandle LoggingOpenFileForReadAndWrite(const base::FilePath& path,
|
|
FileWriteMode mode,
|
|
FilePermissions permissions) {
|
|
FileHandle fd = OpenFileForReadAndWrite(path, mode, permissions);
|
|
PLOG_IF(ERROR, fd < 0) << "open " << path.value();
|
|
return fd;
|
|
}
|
|
|
|
bool LoggingLockFile(FileHandle file, FileLocking locking) {
|
|
int operation = (locking == FileLocking::kShared) ? LOCK_SH : LOCK_EX;
|
|
int rv = HANDLE_EINTR(flock(file, operation));
|
|
PLOG_IF(ERROR, rv != 0) << "flock";
|
|
return rv == 0;
|
|
}
|
|
|
|
bool LoggingUnlockFile(FileHandle file) {
|
|
int rv = flock(file, LOCK_UN);
|
|
PLOG_IF(ERROR, rv != 0) << "flock";
|
|
return rv == 0;
|
|
}
|
|
|
|
FileOffset LoggingSeekFile(FileHandle file, FileOffset offset, int whence) {
|
|
off_t rv = lseek(file, offset, whence);
|
|
PLOG_IF(ERROR, rv < 0) << "lseek";
|
|
return rv;
|
|
}
|
|
|
|
bool LoggingTruncateFile(FileHandle file) {
|
|
if (HANDLE_EINTR(ftruncate(file, 0)) != 0) {
|
|
PLOG(ERROR) << "ftruncate";
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool LoggingCloseFile(FileHandle file) {
|
|
int rv = IGNORE_EINTR(close(file));
|
|
PLOG_IF(ERROR, rv != 0) << "close";
|
|
return rv == 0;
|
|
}
|
|
|
|
FileOffset LoggingFileSizeByHandle(FileHandle file) {
|
|
struct stat st;
|
|
if (fstat(file, &st) != 0) {
|
|
PLOG(ERROR) << "fstat";
|
|
return -1;
|
|
}
|
|
return st.st_size;
|
|
}
|
|
|
|
FileHandle StdioFileHandle(StdioStream stdio_stream) {
|
|
switch (stdio_stream) {
|
|
case StdioStream::kStandardInput:
|
|
return STDIN_FILENO;
|
|
case StdioStream::kStandardOutput:
|
|
return STDOUT_FILENO;
|
|
case StdioStream::kStandardError:
|
|
return STDERR_FILENO;
|
|
}
|
|
|
|
NOTREACHED();
|
|
return kInvalidFileHandle;
|
|
}
|
|
|
|
} // namespace crashpad
|