mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-31 01:43:03 +08:00
cc166d71f4
This is a follow-up to c8a016b99d97, following the post-landing discussion at https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7 base::size, and std::size that will eventually replace it when C++17 is assured, does not allow the size of non-static data members to be taken in constant expression context. The remaining uses of ArraySize are in: minidump/minidump_exception_writer.cc (×1) minidump/minidump_system_info_writer.cc (×2, also uses base::size) snapshot/cpu_context.cc (×4, also uses base::size) util/misc/arraysize_test.cc (×10, of course) The first of these occurs when initializing a constexpr variable. All others are in expressions used with static_assert. Includes: Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao f701716d9546 Add Windows ARM64 build target to mini_chromium 87a95a3d6ac2 Remove the arraysize macro 1f7255ead1f7 Placate MSVC in areas of base::size usage 737433ebade4 Add cast Bug: chromium:837308 Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19 Reviewed-on: https://chromium-review.googlesource.com/c/1396108 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
93 lines
2.7 KiB
C++
93 lines
2.7 KiB
C++
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/stdlib/thread_safe_vector.h"
|
|
|
|
#include "base/stl_util.h"
|
|
#include "gtest/gtest.h"
|
|
#include "util/thread/thread.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
constexpr int kElementsPerThread = 100;
|
|
|
|
class ThreadSafeVectorTestThread : public Thread {
|
|
public:
|
|
ThreadSafeVectorTestThread() : thread_safe_vector_(nullptr), start_(0) {}
|
|
~ThreadSafeVectorTestThread() {}
|
|
|
|
void SetTestParameters(ThreadSafeVector<int>* thread_safe_vector, int start) {
|
|
thread_safe_vector_ = thread_safe_vector;
|
|
start_ = start;
|
|
}
|
|
|
|
// Thread:
|
|
void ThreadMain() override {
|
|
for (int i = start_; i < start_ + kElementsPerThread; ++i) {
|
|
thread_safe_vector_->PushBack(i);
|
|
}
|
|
}
|
|
|
|
private:
|
|
ThreadSafeVector<int>* thread_safe_vector_;
|
|
int start_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(ThreadSafeVectorTestThread);
|
|
};
|
|
|
|
TEST(ThreadSafeVector, ThreadSafeVector) {
|
|
ThreadSafeVector<int> thread_safe_vector;
|
|
std::vector<int> vector = thread_safe_vector.Drain();
|
|
EXPECT_TRUE(vector.empty());
|
|
|
|
ThreadSafeVectorTestThread threads[100];
|
|
for (size_t index = 0; index < base::size(threads); ++index) {
|
|
threads[index].SetTestParameters(
|
|
&thread_safe_vector, static_cast<int>(index * kElementsPerThread));
|
|
}
|
|
|
|
for (size_t index = 0; index < base::size(threads); ++index) {
|
|
threads[index].Start();
|
|
|
|
if (index % 10 == 0) {
|
|
// Drain the vector periodically to test that simultaneous Drain() and
|
|
// PushBack() operations work properly.
|
|
std::vector<int> drained = thread_safe_vector.Drain();
|
|
vector.insert(vector.end(), drained.begin(), drained.end());
|
|
}
|
|
}
|
|
|
|
for (ThreadSafeVectorTestThread& thread : threads) {
|
|
thread.Join();
|
|
}
|
|
|
|
std::vector<int> drained = thread_safe_vector.Drain();
|
|
vector.insert(vector.end(), drained.begin(), drained.end());
|
|
bool found[base::size(threads) * kElementsPerThread] = {};
|
|
EXPECT_EQ(vector.size(), base::size(found));
|
|
for (int element : vector) {
|
|
EXPECT_FALSE(found[element]) << element;
|
|
found[element] = true;
|
|
}
|
|
|
|
vector = thread_safe_vector.Drain();
|
|
EXPECT_TRUE(vector.empty());
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|