crashpad/util/mach/exception_behaviors_test.cc
Mark Mentovai cc166d71f4 Use base::size where appropriate, and ArraySize elsewhere
This is a follow-up to c8a016b99d97, following the post-landing
discussion at
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7

base::size, and std::size that will eventually replace it when C++17 is
assured, does not allow the size of non-static data members to be taken
in constant expression context. The remaining uses of ArraySize are in:

minidump/minidump_exception_writer.cc (×1)
minidump/minidump_system_info_writer.cc (×2, also uses base::size)
snapshot/cpu_context.cc (×4, also uses base::size)
util/misc/arraysize_test.cc (×10, of course)

The first of these occurs when initializing a constexpr variable. All
others are in expressions used with static_assert.

Includes:
Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao

f701716d9546 Add Windows ARM64 build target to mini_chromium
87a95a3d6ac2 Remove the arraysize macro
1f7255ead1f7 Placate MSVC in areas of base::size usage
737433ebade4 Add cast

Bug: chromium:837308
Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19
Reviewed-on: https://chromium-review.googlesource.com/c/1396108
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-01-04 22:42:57 +00:00

74 lines
2.3 KiB
C++

// Copyright 2014 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "util/mach/exception_behaviors.h"
#include <sys/types.h>
#include "base/stl_util.h"
#include "base/strings/stringprintf.h"
#include "gtest/gtest.h"
#include "util/mach/mach_extensions.h"
namespace crashpad {
namespace test {
namespace {
TEST(ExceptionBehaviors, ExceptionBehaviors) {
static constexpr struct {
exception_behavior_t behavior;
bool state;
bool identity;
bool mach_exception_codes;
exception_behavior_t basic_behavior;
} kTestData[] = {
{EXCEPTION_DEFAULT, false, true, false, EXCEPTION_DEFAULT},
{EXCEPTION_STATE, true, false, false, EXCEPTION_STATE},
{EXCEPTION_STATE_IDENTITY, true, true, false, EXCEPTION_STATE_IDENTITY},
{kMachExceptionCodes | EXCEPTION_DEFAULT,
false,
true,
true,
EXCEPTION_DEFAULT},
{kMachExceptionCodes | EXCEPTION_STATE,
true,
false,
true,
EXCEPTION_STATE},
{kMachExceptionCodes | EXCEPTION_STATE_IDENTITY,
true,
true,
true,
EXCEPTION_STATE_IDENTITY},
};
for (size_t index = 0; index < base::size(kTestData); ++index) {
const auto& test_data = kTestData[index];
SCOPED_TRACE(base::StringPrintf(
"index %zu, behavior %d", index, test_data.behavior));
EXPECT_EQ(ExceptionBehaviorHasState(test_data.behavior), test_data.state);
EXPECT_EQ(ExceptionBehaviorHasIdentity(test_data.behavior),
test_data.identity);
EXPECT_EQ(ExceptionBehaviorHasMachExceptionCodes(test_data.behavior),
test_data.mach_exception_codes);
EXPECT_EQ(ExceptionBehaviorBasic(test_data.behavior),
test_data.basic_behavior);
}
}
} // namespace
} // namespace test
} // namespace crashpad