mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-27 15:32:10 +08:00
Mark Mentovai
d25b0242c6
gn: Fix a couple of things after 9465fc72ad90 and 2bb56fafe3bd
When I redid the Crashpad GN build a few weeks ago (https://chromium-review.googlesource.com/c/chromium/src/+/751403), I tried to order things according to the GN style guide (https://chromium.googlesource.com/chromium/src/tools/gn/+/HEAD/docs/style_guide.md). As for conditionals, I tried to stick to doing a set of conditionals after “sources” for just “sources”, and then another one at the bottom for everything else. It turns out that this was a good idea because it’s an error to say “deps += [something]” inside a conditional until you’ve already said “deps = [something_else]” first. (Maybe that’s why I did it.) 9465fc72ad90 regressed this. 2bb56fafe3bd also left behind a couple of straggler paths that were absolute to Chromium’s root but should have been made relative. This also fixes a comment (about something that won’t yet work outside of Chromium anyway, but still…) Bug: crashpad:79 Change-Id: I8a6f84bfad368cbcdae4fbff11f1d00e2af14b93 Reviewed-on: https://chromium-review.googlesource.com/798172 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org>
Crashpad
Crashpad is a crash-reporting system.
Documentation
- Project status
- Developing Crashpad: instructions for getting the source code, building, testing, and contributing to the project.
- Crashpad interface documentation
- Crashpad tool man pages
- Crashpad overview design
Source Code
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.
Other Links
- Bugs can be reported at the Crashpad issue tracker.
- The Crashpad Buildbots perform automated builds and tests.
- crashpad-dev is the Crashpad developers’ mailing list.
Description
Languages
C++
92.6%
Objective-C++
2.5%
C
2%
Python
1.7%
Assembly
0.9%
Other
0.3%