mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-31 01:43:03 +08:00
cc166d71f4
This is a follow-up to c8a016b99d97, following the post-landing discussion at https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7 base::size, and std::size that will eventually replace it when C++17 is assured, does not allow the size of non-static data members to be taken in constant expression context. The remaining uses of ArraySize are in: minidump/minidump_exception_writer.cc (×1) minidump/minidump_system_info_writer.cc (×2, also uses base::size) snapshot/cpu_context.cc (×4, also uses base::size) util/misc/arraysize_test.cc (×10, of course) The first of these occurs when initializing a constexpr variable. All others are in expressions used with static_assert. Includes: Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao f701716d9546 Add Windows ARM64 build target to mini_chromium 87a95a3d6ac2 Remove the arraysize macro 1f7255ead1f7 Placate MSVC in areas of base::size usage 737433ebade4 Add cast Bug: chromium:837308 Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19 Reviewed-on: https://chromium-review.googlesource.com/c/1396108 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
92 lines
3.1 KiB
C++
92 lines
3.1 KiB
C++
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/process/process_memory_range.h"
|
|
|
|
#include <limits>
|
|
|
|
#include "base/logging.h"
|
|
#include "base/stl_util.h"
|
|
#include "build/build_config.h"
|
|
#include "gtest/gtest.h"
|
|
#include "test/process_type.h"
|
|
#include "util/misc/from_pointer_cast.h"
|
|
#include "util/process/process_memory_native.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
struct TestObject {
|
|
char string1[16];
|
|
char string2[16];
|
|
} kTestObject = {"string1", "string2"};
|
|
|
|
TEST(ProcessMemoryRange, Basic) {
|
|
#if defined(ARCH_CPU_64_BITS)
|
|
constexpr bool is_64_bit = true;
|
|
#else
|
|
constexpr bool is_64_bit = false;
|
|
#endif // ARCH_CPU_64_BITS
|
|
|
|
ProcessMemoryNative memory;
|
|
ASSERT_TRUE(memory.Initialize(GetSelfProcess()));
|
|
|
|
ProcessMemoryRange range;
|
|
ASSERT_TRUE(range.Initialize(&memory, is_64_bit));
|
|
EXPECT_EQ(range.Is64Bit(), is_64_bit);
|
|
|
|
// Both strings are accessible within the object's range.
|
|
auto object_addr = FromPointerCast<VMAddress>(&kTestObject);
|
|
EXPECT_TRUE(range.RestrictRange(object_addr, sizeof(kTestObject)));
|
|
|
|
TestObject object;
|
|
ASSERT_TRUE(range.Read(object_addr, sizeof(object), &object));
|
|
EXPECT_EQ(memcmp(&object, &kTestObject, sizeof(object)), 0);
|
|
|
|
std::string string;
|
|
auto string1_addr = FromPointerCast<VMAddress>(kTestObject.string1);
|
|
auto string2_addr = FromPointerCast<VMAddress>(kTestObject.string2);
|
|
ASSERT_TRUE(range.ReadCStringSizeLimited(
|
|
string1_addr, base::size(kTestObject.string1), &string));
|
|
EXPECT_STREQ(string.c_str(), kTestObject.string1);
|
|
|
|
ASSERT_TRUE(range.ReadCStringSizeLimited(
|
|
string2_addr, base::size(kTestObject.string2), &string));
|
|
EXPECT_STREQ(string.c_str(), kTestObject.string2);
|
|
|
|
// Limit the range to remove access to string2.
|
|
ProcessMemoryRange range2;
|
|
ASSERT_TRUE(range2.Initialize(range));
|
|
ASSERT_TRUE(
|
|
range2.RestrictRange(string1_addr, base::size(kTestObject.string1)));
|
|
EXPECT_TRUE(range2.ReadCStringSizeLimited(
|
|
string1_addr, base::size(kTestObject.string1), &string));
|
|
EXPECT_FALSE(range2.ReadCStringSizeLimited(
|
|
string2_addr, base::size(kTestObject.string2), &string));
|
|
EXPECT_FALSE(range2.Read(object_addr, sizeof(object), &object));
|
|
|
|
// String reads fail if the NUL terminator is outside the range.
|
|
ASSERT_TRUE(range2.RestrictRange(string1_addr, strlen(kTestObject.string1)));
|
|
EXPECT_FALSE(range2.ReadCStringSizeLimited(
|
|
string1_addr, base::size(kTestObject.string1), &string));
|
|
|
|
// New range outside the old range.
|
|
EXPECT_FALSE(range2.RestrictRange(string1_addr - 1, 1));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|