crashpad/test/win/win_multiprocess.cc
Mark Mentovai 4688351623 “Promote” test::Paths::Executable() to Paths::Executable()
This supports the “double handler” or “double handler with low
probability” models from https://crashpad.chromium.org/bug/143.

For crashpad_handler to be become its own client, it needs access to its
own executable path to pass to CrashpadClient::StartHandler(). This was
formerly available in the test-only test::Paths::Executable(). Bring
that function’s implementation to the non-test Paths::Executable() in
util/misc, and rename test::Paths to test::TestPaths to avoid future
confusion.

test::TestPaths must still be used to access TestDataRoot(), which does
not make any sense to non-test code.

test::TestPaths::Executable() is retained for use by tests, which most
likely prefer the fatal semantics of that function. Paths::Executable()
is not fatal because for the purposes of implementing the double
handler, a failure to locate the executable path (which may happen on
some systems in deeply-nested directory hierarchies) shouldn’t cause the
initial crashpad_handler to abort, even if it does prevent a second
crashpad_handler from being started.

Bug: crashpad:143
Test: crashpad_util_test Paths.*, crashpad_test_test TestPaths.*
Change-Id: I9f75bf61839ce51e33c9f7c0d7031cebead6a156
Reviewed-on: https://chromium-review.googlesource.com/466346
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
2017-04-03 18:58:01 +00:00

80 lines
2.2 KiB
C++

// Copyright 2015 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "test/win/win_multiprocess.h"
#include <shellapi.h>
#include "base/logging.h"
#include "base/scoped_generic.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "util/stdlib/string_number_conversion.h"
#include "util/string/split_string.h"
namespace crashpad {
namespace test {
WinMultiprocess::WinMultiprocess()
: exit_code_(EXIT_SUCCESS),
child_handles_(nullptr),
child_process_helper_(nullptr) {}
WinMultiprocess::~WinMultiprocess() {
}
void WinMultiprocess::SetExpectedChildExitCode(unsigned int exit_code) {
exit_code_ = exit_code;
}
FileHandle WinMultiprocess::ReadPipeHandle() const {
if (child_handles_)
return child_handles_->read.get();
CHECK(child_process_helper_);
return child_process_helper_->ReadPipeHandleForwarder();
}
FileHandle WinMultiprocess::WritePipeHandle() const {
if (child_handles_)
return child_handles_->write.get();
CHECK(child_process_helper_);
return child_process_helper_->WritePipeHandleForwarder();
}
void WinMultiprocess::CloseReadPipe() {
if (child_handles_) {
child_handles_->read.reset();
} else {
CHECK(child_process_helper_);
child_process_helper_->CloseReadPipeForwarder();
}
}
void WinMultiprocess::CloseWritePipe() {
if (child_handles_) {
child_handles_->write.reset();
} else {
CHECK(child_process_helper_);
child_process_helper_->CloseWritePipeForwarder();
}
}
HANDLE WinMultiprocess::ChildProcess() const {
CHECK(child_handles_);
return child_handles_->process.get();
}
} // namespace test
} // namespace crashpad