mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 08:39:44 +08:00
cc166d71f4
This is a follow-up to c8a016b99d97, following the post-landing discussion at https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7 base::size, and std::size that will eventually replace it when C++17 is assured, does not allow the size of non-static data members to be taken in constant expression context. The remaining uses of ArraySize are in: minidump/minidump_exception_writer.cc (×1) minidump/minidump_system_info_writer.cc (×2, also uses base::size) snapshot/cpu_context.cc (×4, also uses base::size) util/misc/arraysize_test.cc (×10, of course) The first of these occurs when initializing a constexpr variable. All others are in expressions used with static_assert. Includes: Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao f701716d9546 Add Windows ARM64 build target to mini_chromium 87a95a3d6ac2 Remove the arraysize macro 1f7255ead1f7 Placate MSVC in areas of base::size usage 737433ebade4 Add cast Bug: chromium:837308 Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19 Reviewed-on: https://chromium-review.googlesource.com/c/1396108 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
116 lines
4.1 KiB
C++
116 lines
4.1 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#include "util/stdlib/strlcpy.h"
|
||
|
||
#include <string.h>
|
||
#include <wchar.h>
|
||
|
||
#include <algorithm>
|
||
|
||
#include "base/format_macros.h"
|
||
#include "base/stl_util.h"
|
||
#include "base/strings/string16.h"
|
||
#include "base/strings/stringprintf.h"
|
||
#include "gtest/gtest.h"
|
||
|
||
namespace crashpad {
|
||
namespace test {
|
||
namespace {
|
||
|
||
// The base::c16 functions only exist if WCHAR_T_IS_UTF32.
|
||
#if defined(WCHAR_T_IS_UTF32)
|
||
size_t C16Len(const base::char16* s) {
|
||
return base::c16len(s);
|
||
}
|
||
|
||
int C16Memcmp(const base::char16* s1, const base::char16* s2, size_t n) {
|
||
return base::c16memcmp(s1, s2, n);
|
||
}
|
||
#elif defined(WCHAR_T_IS_UTF16)
|
||
size_t C16Len(const base::char16* s) {
|
||
return wcslen(s);
|
||
}
|
||
|
||
int C16Memcmp(const base::char16* s1, const base::char16* s2, size_t n) {
|
||
return wmemcmp(s1, s2, n);
|
||
}
|
||
#endif
|
||
|
||
TEST(strlcpy, c16lcpy) {
|
||
// Use a destination buffer that’s larger than the length passed to c16lcpy.
|
||
// The unused portion is a guard area that must not be written to.
|
||
struct TestBuffer {
|
||
base::char16 lead_guard[64];
|
||
base::char16 data[128];
|
||
base::char16 trail_guard[64];
|
||
};
|
||
TestBuffer expected_untouched;
|
||
memset(&expected_untouched, 0xa5, sizeof(expected_untouched));
|
||
|
||
// Test with M, é, Ā, ő, and Ḙ. This is a mix of characters that have zero and
|
||
// nonzero low and high bytes.
|
||
static constexpr base::char16 test_characters[] =
|
||
{0x4d, 0xe9, 0x100, 0x151, 0x1e18};
|
||
|
||
for (size_t index = 0; index < base::size(test_characters); ++index) {
|
||
base::char16 test_character = test_characters[index];
|
||
SCOPED_TRACE(base::StringPrintf(
|
||
"character index %" PRIuS ", character 0x%x", index, test_character));
|
||
for (size_t length = 0; length < 256; ++length) {
|
||
SCOPED_TRACE(
|
||
base::StringPrintf("index %" PRIuS, length));
|
||
base::string16 test_string(length, test_character);
|
||
|
||
TestBuffer destination;
|
||
memset(&destination, 0xa5, sizeof(destination));
|
||
|
||
EXPECT_EQ(c16lcpy(destination.data,
|
||
test_string.c_str(),
|
||
base::size(destination.data)),
|
||
length);
|
||
|
||
// Make sure that the destination buffer is NUL-terminated, and that as
|
||
// much of the test string was copied as could fit.
|
||
size_t expected_destination_length =
|
||
std::min(length, base::size(destination.data) - 1);
|
||
|
||
EXPECT_EQ(destination.data[expected_destination_length], '\0');
|
||
EXPECT_EQ(C16Len(destination.data), expected_destination_length);
|
||
EXPECT_TRUE(C16Memcmp(test_string.c_str(),
|
||
destination.data,
|
||
expected_destination_length) == 0);
|
||
|
||
// Make sure that the portion of the destination buffer that was not used
|
||
// was not touched. This includes the guard areas and the unused portion
|
||
// of the buffer passed to c16lcpy.
|
||
EXPECT_TRUE(C16Memcmp(expected_untouched.lead_guard,
|
||
destination.lead_guard,
|
||
base::size(destination.lead_guard)) == 0);
|
||
size_t expected_untouched_length =
|
||
base::size(destination.data) - expected_destination_length - 1;
|
||
EXPECT_TRUE(C16Memcmp(expected_untouched.data,
|
||
&destination.data[expected_destination_length + 1],
|
||
expected_untouched_length) == 0);
|
||
EXPECT_TRUE(C16Memcmp(expected_untouched.trail_guard,
|
||
destination.trail_guard,
|
||
base::size(destination.trail_guard)) == 0);
|
||
}
|
||
}
|
||
}
|
||
|
||
} // namespace
|
||
} // namespace test
|
||
} // namespace crashpad
|