mirror of https://github.com/chromium/crashpad.git synced 2025-03-09 14:06:33 +00:00

Go to file

Mark Mentovai c6adcc2482 win: Make CrashpadClient::DumpAndCrashTargetProcess() less chatty

CrashpadClient::DumpAndCrashTargetProcess() suspends the target process
and injects a thread to raise an exception. The injected thread is not
suspended, and may proceed to the point that the system recognizes the
process as terminating by the time the overall process suspension is
lifted. Previously, if this happened, an extraneous error was logged for
the attempt to resume a terminating process.

This introduces “termination tolerance” to ScopedProcessSuspend, which
allows an object to be configured to ignore this error and not log any
messages when this condition is expected.

This resolves log messages such as this one, produced frequently during
calls to CrashpadClient::DumpAndCrashTargetProcess() (including in
end_to_end_test.py):

> [pid:tid:yyyymmdd,hhmmss.mmm:ERROR scoped_process_suspend.cc:39]
> NtResumeProcess: An attempt was made to access an exiting process.
> (0xc000010a)

0xc000010a = STATUS_PROCESS_IS_TERMINATING

Test: end_to_end_test.py
Change-Id: Iab4c50fb21adce5502080ad25a6f734ec566d65c
Reviewed-on: https://chromium-review.googlesource.com/700715
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>

2017-10-04 19:04:47 +00:00

build

Add SystemSnapshotLinux

2017-08-08 22:31:46 +00:00

client

win: Make CrashpadClient::DumpAndCrashTargetProcess() less chatty

2017-10-04 19:04:47 +00:00

compat

linux: Add ExceptionSnapshotLinux

2017-08-02 02:29:51 +00:00

doc

doc: Update for NDK r15b