crashpad/test/test_paths.cc
Mark Mentovai 1669ca2bac test: Rework TestPaths interface for obtaining 32-bit build artifacts
The design for running all Crashpad unit tests on Chromium’s try- and
buildbots involves pulling all tests into a single monolithic
crashpad_tests executable. Many Crashpad tests base the name of their
child executables or modules on the name of the main test executable.
Since the main test executable will have a different name in the
in-Chromium build, knowledge of the test executable name (referred to as
“module” here) needs to be added to the tests themselves.

This introduces TestPaths::BuildArtifact(), which allows the module name
to be specified. For Crashpad’s standalone build, the module name is
verified against the main test executable’s name.
TestPaths::BuildArtifact() can also locate paths in the alternate 32-bit
output directory for 64-bit Windows tests, taking on the responsibility
for what the new (5e9ed4cb9f69) TestPaths::Output32BitDirectory(), now
obsolete, did.

Bug: chromium:779790
Change-Id: I64c4a2190b6319e487c999812a7cfc512a75a700
Reviewed-on: https://chromium-review.googlesource.com/747536
Reviewed-by: Scott Graham <scottmg@chromium.org>
2017-11-01 16:44:45 +00:00

187 lines
5.4 KiB
C++
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

// Copyright 2015 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "test/test_paths.h"
#include <stdlib.h>
#include <sys/stat.h>
#include "base/logging.h"
#include "build/build_config.h"
#include "util/misc/paths.h"
namespace crashpad {
namespace test {
namespace {
bool IsTestDataRoot(const base::FilePath& candidate) {
const base::FilePath marker_path =
candidate.Append(FILE_PATH_LITERAL("test"))
.Append(FILE_PATH_LITERAL("test_paths_test_data_root.txt"));
#if !defined(OS_WIN)
struct stat stat_buf;
int rv = stat(marker_path.value().c_str(), &stat_buf);
#else
struct _stat stat_buf;
int rv = _wstat(marker_path.value().c_str(), &stat_buf);
#endif
return rv == 0;
}
base::FilePath TestDataRootInternal() {
#if !defined(OS_WIN)
const char* environment_value = getenv("CRASHPAD_TEST_DATA_ROOT");
#else // defined(OS_WIN)
const wchar_t* environment_value = _wgetenv(L"CRASHPAD_TEST_DATA_ROOT");
#endif
if (environment_value) {
// It was specified explicitly, so use it even if it seems incorrect.
if (!IsTestDataRoot(base::FilePath(environment_value))) {
LOG(WARNING) << "CRASHPAD_TEST_DATA_ROOT seems invalid, honoring anyway";
}
return base::FilePath(environment_value);
}
// In a standalone build, the test executable is usually at
// out/{Debug,Release} relative to the Crashpad root.
base::FilePath executable_path;
if (Paths::Executable(&executable_path)) {
base::FilePath candidate =
base::FilePath(executable_path.DirName()
.Append(base::FilePath::kParentDirectory)
.Append(base::FilePath::kParentDirectory));
if (IsTestDataRoot(candidate)) {
return candidate;
}
// In an in-Chromium build, the test executable is usually at
// out/{Debug,Release} relative to the Chromium root, and the Crashpad root
// is at third_party/crashpad/crashpad relative to the Chromium root.
candidate = candidate.Append(FILE_PATH_LITERAL("third_party"))
.Append(FILE_PATH_LITERAL("crashpad"))
.Append(FILE_PATH_LITERAL("crashpad"));
if (IsTestDataRoot(candidate)) {
return candidate;
}
}
// If nothing else worked, use the current directory, issuing a warning if it
// doesnt seem right.
if (!IsTestDataRoot(base::FilePath(base::FilePath::kCurrentDirectory))) {
LOG(WARNING) << "could not locate a valid test data root";
}
return base::FilePath(base::FilePath::kCurrentDirectory);
}
#if defined(OS_WIN) && defined(ARCH_CPU_64_BITS)
// Returns the pathname of a directory containing 32-bit test build output.
//
// It would be better for this to be named 32BitOutputDirectory(), but thats
// not a legal name.
base::FilePath Output32BitDirectory() {
const wchar_t* environment_value = _wgetenv(L"CRASHPAD_TEST_32_BIT_OUTPUT");
if (!environment_value) {
return base::FilePath();
}
return base::FilePath(environment_value);
}
#endif // defined(OS_WIN) && defined(ARCH_CPU_64_BITS)
} // namespace
// static
base::FilePath TestPaths::Executable() {
base::FilePath executable_path;
CHECK(Paths::Executable(&executable_path));
return executable_path;
}
// static
base::FilePath TestPaths::TestDataRoot() {
static base::FilePath* test_data_root =
new base::FilePath(TestDataRootInternal());
return *test_data_root;
}
// static
base::FilePath TestPaths::BuildArtifact(
const base::FilePath::StringType& module,
const base::FilePath::StringType& artifact,
FileType file_type,
Architecture architecture) {
base::FilePath directory;
switch (architecture) {
case Architecture::kDefault:
directory = Executable().DirName();
break;
#if defined(OS_WIN) && defined(ARCH_CPU_64_BITS)
case Architecture::k32Bit:
directory = Output32BitDirectory();
CHECK(!directory.empty());
break;
#endif // OS_WIN && ARCH_CPU_64_BITS
}
base::FilePath::StringType test_name =
FILE_PATH_LITERAL("crashpad_") + module + FILE_PATH_LITERAL("_test");
#if !defined(CRASHPAD_IN_CHROMIUM)
CHECK(Executable().BaseName().RemoveFinalExtension().value() == test_name);
#endif // !CRASHPAD_IN_CHROMIUM
base::FilePath::StringType extension;
switch (file_type) {
case FileType::kNone:
break;
case FileType::kExecutable:
#if defined(OS_WIN)
extension = FILE_PATH_LITERAL(".exe");
#endif // OS_WIN
break;
case FileType::kLoadableModule:
#if defined(OS_WIN)
extension = FILE_PATH_LITERAL(".dll");
#else // OS_WIN
extension = FILE_PATH_LITERAL(".so");
#endif // OS_WIN
break;
}
return directory.Append(test_name + FILE_PATH_LITERAL("_") + artifact +
extension);
}
#if defined(OS_WIN) && defined(ARCH_CPU_64_BITS)
// static
bool TestPaths::Has32BitBuildArtifacts() {
return !Output32BitDirectory().empty();
}
#endif // defined(OS_WIN) && defined(ARCH_CPU_64_BITS)
} // namespace test
} // namespace crashpad