mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-31 01:43:03 +08:00
f09d0cde00
The database settings object’s last_upload_attempt_time (time_t) field is switched from uint64_t to int64_t, for better compatibility with time_t, which is normally a signed type. This change should be transparent, as there should be no valid high-bit-set 64-bit timestamps in this field in the wild. A number of improvements are made to crashpad_database_util’s time handling. Errors are checked during time conversion. --set-last-upload-attempt-time=now is a new supported (and documented) option. A StringToNumber() overload for int64_t, along with a test, is added to aid in crashpad_database_util’s time conversions from numeric strings. A test is also added for the previously-untested uint64_t implementation. TEST=crashpad_util_test StringNumberConversion.* Change-Id: I089c4bf7b95f5df0982bdbb3c27b4f6a89db966e Reviewed-on: https://chromium-review.googlesource.com/410068 Reviewed-by: Robert Sesek <rsesek@chromium.org>
66 lines
3.0 KiB
C++
66 lines
3.0 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#ifndef CRASHPAD_UTIL_STDLIB_STRING_NUMBER_CONVERSION_H_
|
||
#define CRASHPAD_UTIL_STDLIB_STRING_NUMBER_CONVERSION_H_
|
||
|
||
#include "base/strings/string_piece.h"
|
||
|
||
namespace crashpad {
|
||
|
||
// Convert between strings and numbers.
|
||
//
|
||
// These functions will only set *number if a perfect conversion can be
|
||
// performed. A perfect conversion contains no leading or trailing characters
|
||
// (including whitespace) other than the number to convert, and does not
|
||
// overflow the targeted data type. If a perfect conversion is possible, *number
|
||
// is set and these functions return true. Otherwise, they return false.
|
||
//
|
||
// The interface in base/strings/string_number_conversions.h doesn’t allow
|
||
// arbitrary bases based on whether the string begins with prefixes such as "0x"
|
||
// as strtol does with base = 0. The functions here are implemented on the
|
||
// strtol family with base = 0, and thus do accept such input.
|
||
|
||
//! \{
|
||
//! \brief Convert a string to a number.
|
||
//!
|
||
//! A conversion will only be performed if it can be done perfectly: if \a
|
||
//! string contains no leading or trailing characters (including whitespace)
|
||
//! other than the number to convert, and does not overflow the targeted data
|
||
//! type.
|
||
//!
|
||
//! \param[in] string The string to convert to a number. As in `strtol()` with a
|
||
//! `base` parameter of `0`, the string is treated as decimal unless it
|
||
//! begins with a `"0x"` or `"0X"` prefix, in which case it is treated as
|
||
//! hexadecimal, or a `"0"` prefix, in which case it is treated as octal.
|
||
//! \param[out] number The converted number. This will only be set if a perfect
|
||
//! conversion can be performed.
|
||
//!
|
||
//! \return `true` if a perfect conversion could be performed, with \a number
|
||
//! set appropriately. `false` if a perfect conversion was not possible.
|
||
//!
|
||
//! \note The interface in `base/strings/string_number_conversions.h` doesn’t
|
||
//! allow arbitrary bases based on whether the string begins with a prefix
|
||
//! indicating its base. The functions here are provided for situations
|
||
//! where such prefix recognition is desirable.
|
||
bool StringToNumber(const base::StringPiece& string, int* number);
|
||
bool StringToNumber(const base::StringPiece& string, unsigned int* number);
|
||
bool StringToNumber(const base::StringPiece& string, int64_t* number);
|
||
bool StringToNumber(const base::StringPiece& string, uint64_t* number);
|
||
//! \}
|
||
|
||
} // namespace crashpad
|
||
|
||
#endif // CRASHPAD_UTIL_STDLIB_STRING_NUMBER_CONVERSION_H_
|