mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-31 01:43:03 +08:00
acabe35928
This makes Doxygen’s output more actionable by setting QUIET = YES to suppress verbose progress spew, and WARN_IF_UNDOCUMENTED = NO to prevent warnings for undocumented classes and members from being generated. The latter is too noisy, producing 721 warnings in the current codebase. The remaining warnings produced by Doxygen were useful and actionable. They fell into two categories: abuses of Doxygen’s markup syntax, and missing (or misspelled) parameter documentation. In a small number of cases, pass-through parameters had intentionally been left undocumented. In these cases, they are now given blank \param descriptions. This is not optimal, but there doesn’t appear to be any other way to tell Doxygen to allow a single parameter to be undocumented. Some tricky Doxygen errors were resolved by asking it to not enter directiores that we do not provide documentation in (such as the “on-platform” compat directories, compat/mac and compat/win, as well as compat/non_cxx11_lib) while allowing it to enter the “off-platform” directories that we do document (compat/non_mac and compat/non_win). A Doxygen run (doc/support/generate_doxygen.sh) now produces no output at all. It would produce warnings if any were triggered. Not directly related, but still relevant to documentation, doc/support/generate.sh is updated to remove temporary removals of now-extinct files and directories. doc/appengine/README is updated so that a consistent path to “goapp” is used throughout the file. Change-Id: I300730c04de4d3340551ea3086ca70cc5ff862d1 Reviewed-on: https://chromium-review.googlesource.com/408812 Reviewed-by: Robert Sesek <rsesek@chromium.org>
57 lines
2.1 KiB
C++
57 lines
2.1 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef CRASHPAD_UTIL_STDLIB_MAP_INSERT_H_
|
|
#define CRASHPAD_UTIL_STDLIB_MAP_INSERT_H_
|
|
|
|
#include <map>
|
|
#include <utility>
|
|
|
|
namespace crashpad {
|
|
|
|
//! \brief Inserts a mapping from \a key to \a value into \a map, or replaces
|
|
//! an existing mapping so that \a key maps to \a value.
|
|
//!
|
|
//! This behaves similarly to `std::map<>::%insert_or_assign()` proposed for
|
|
//! C++17, except that the \a old_value parameter is added.
|
|
//!
|
|
//! \param[in,out] map The map to operate on.
|
|
//! \param[in] key The key that should be mapped to \a value.
|
|
//! \param[in] value The value that \a key should map to.
|
|
//! \param[out] old_value If \a key was previously present in \a map, this will
|
|
//! be set to its previous value. This parameter is optional and may be
|
|
//! `nullptr` if this information is not required.
|
|
//!
|
|
//! \return `false` if \a key was previously present in \a map. If \a old_value
|
|
//! is not `nullptr`, it will be set to the previous value. `true` if \a
|
|
//! key was not present in the map and was inserted.
|
|
template <typename T>
|
|
bool MapInsertOrReplace(T* map,
|
|
const typename T::key_type& key,
|
|
const typename T::mapped_type& value,
|
|
typename T::mapped_type* old_value) {
|
|
const auto result = map->insert(std::make_pair(key, value));
|
|
if (!result.second) {
|
|
if (old_value) {
|
|
*old_value = result.first->second;
|
|
}
|
|
result.first->second = value;
|
|
}
|
|
return result.second;
|
|
}
|
|
|
|
} // namespace crashpad
|
|
|
|
#endif // CRASHPAD_UTIL_STDLIB_MAP_INSERT_H_
|