mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-26 23:01:05 +08:00
1c37daa5ac
This is a reland of 460943dd9a71dc76f68182a8ede766d5543e5341
Original change's description:
> The DoubleForkAndExec() function was taking over 622 milliseconds to run
> on macOS 11 (BigSur) on Intel i5-1038NG7. I did some debugging by adding
> some custom traces and found that the fork() syscall is the bottleneck
> here, i.e., the first fork() takes around 359 milliseconds and the
> nested fork() takes around 263 milliseconds. Replacing the nested fork()
> and exec() with posix_spawn() reduces the time consumption to 257
> milliseconds!
>
> See https://github.com/libuv/libuv/pull/3064 to know why fork() is so
> slow on macOS and why posix_spawn() is a better replacement.
>
> Another point to note is that even base::LaunchProcess() from Chromium
> calls posix_spawnp() on macOS -
> 8f8d82dea0:base/process/launch_mac.cc;l=295-296
The reland isolates the change to non-Android POSIX systems because
posix_spawn and posix_spawnp are available in Android NDK 28, but
Chromium is building with version 23.
Change-Id: If44629f5445bb0e3d0a1d3698b85f047d1cbf04f
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3721655
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
16 lines
444 B
Plaintext
16 lines
444 B
Plaintext
# This is the official list of Crashpad authors for copyright purposes.
|
|
# This file is distinct from the CONTRIBUTORS files.
|
|
# See the latter for an explanation.
|
|
|
|
# Names should be added to this file as:
|
|
# Name or Organization <email address>
|
|
# The email address is not required for organizations.
|
|
|
|
Google Inc.
|
|
Intel Corporation
|
|
Opera Software ASA
|
|
Vewd Software AS
|
|
LG Electronics, Inc.
|
|
MIPS Technologies, Inc.
|
|
Darshan Sen <raisinten@gmail.com>
|