mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-09 22:26:06 +00:00
7faa2ef898
Embeds the address of g_crashpad_info into a .note section (which is readable by the generic code to read notes in ElfImageReader). Unfortunately because the note section is in libclient.a, it would normally be dropped at link time. To avoid that, GetCrashpadInfo() has a reference *back* to that section, which in turn forces the linker to include it, allowing the note reader to find it at runtime. Previously, it was necessary to have the embedder of "client" figure out how to cause `g_crashpad_info` to appear in the final module's dynamic symbol table. With this new approach, there's no manual configuration necessary, as it's not necessary for the symbol to be exported. This is currently only implemented in the Linux module reader (and I believe the current set of enabled tests aren't exercising it?) but it will also be done this way for the Fuchsia implementation of ModuleSnapshot. Bug: crashpad:196 Change-Id: I599db5903bc98303130d11ad850ba9ceed3b801a Reviewed-on: https://chromium-review.googlesource.com/912284 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
47 lines
1.6 KiB
ArmAsm
47 lines
1.6 KiB
ArmAsm
// Copyright 2018 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
// This note section is used on ELF platforms to give ElfImageReader a method
|
|
// of finding the instance of CrashpadInfo g_crashpad_info without requiring
|
|
// that symbol to be in the dynamic symbol table.
|
|
|
|
#include "util/misc/elf_note_types.h"
|
|
|
|
// namespace crashpad {
|
|
// CrashpadInfo g_crashpad_info;
|
|
// } // namespace crashpad
|
|
#define CRASHPAD_INFO_SYMBOL _ZN8crashpad15g_crashpad_infoE
|
|
|
|
#define NOTE_ALIGN 4
|
|
|
|
// This section must be "a"llocated so that it appears in the final binary at
|
|
// runtime, and "w"ritable so that the relocation to CRASHPAD_INFO_SYMBOL can
|
|
// be performed.
|
|
.section .note.crashpad.info,"aw",%note
|
|
.balign NOTE_ALIGN
|
|
.globl CRASHPAD_NOTE_REFERENCE
|
|
.type CRASHPAD_NOTE_REFERENCE, %object
|
|
CRASHPAD_NOTE_REFERENCE:
|
|
.long name_end - name // namesz
|
|
.long desc_end - desc // descsz
|
|
.long CRASHPAD_ELF_NOTE_TYPE_CRASHPAD_INFO // type
|
|
name:
|
|
.asciz CRASHPAD_ELF_NOTE_NAME
|
|
name_end:
|
|
.balign NOTE_ALIGN
|
|
desc:
|
|
.quad CRASHPAD_INFO_SYMBOL
|
|
desc_end:
|
|
.size CRASHPAD_NOTE_REFERENCE, .-CRASHPAD_NOTE_REFERENCE
|