mirror of
https://github.com/chromium/crashpad.git
synced 2025-01-21 15:11:37 +08:00
4b450c8137
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
77d6b17338
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
309 lines
10 KiB
Plaintext
309 lines
10 KiB
Plaintext
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#include "util/mac/launchd.h"
|
||
|
||
#import <Foundation/Foundation.h>
|
||
#include <launch.h>
|
||
#include <stdint.h>
|
||
#include <string.h>
|
||
|
||
#include <cmath>
|
||
#include <limits>
|
||
|
||
#include "base/mac/scoped_launch_data.h"
|
||
#include "base/macros.h"
|
||
#include "gtest/gtest.h"
|
||
#include "util/stdlib/objc.h"
|
||
|
||
namespace crashpad {
|
||
namespace test {
|
||
namespace {
|
||
|
||
TEST(Launchd, CFPropertyToLaunchData_Integer) {
|
||
@autoreleasepool {
|
||
base::mac::ScopedLaunchData launch_data;
|
||
|
||
NSNumber* integer_nses[] = {
|
||
@0,
|
||
@1,
|
||
@-1,
|
||
@0x7f,
|
||
@0x80,
|
||
@0xff,
|
||
@0x0100,
|
||
@0x7fff,
|
||
@0x8000,
|
||
@0xffff,
|
||
@0x00010000,
|
||
@0x7fffffff,
|
||
@0x80000000,
|
||
@0xffffffff,
|
||
@0x1000000000000000,
|
||
@0x7fffffffffffffff,
|
||
@0x8000000000000000,
|
||
@0xffffffffffffffff,
|
||
@0x0123456789abcdef,
|
||
@0xfedcba9876543210,
|
||
};
|
||
|
||
for (size_t index = 0; index < arraysize(integer_nses); ++index) {
|
||
NSNumber* integer_ns = integer_nses[index];
|
||
launch_data.reset(CFPropertyToLaunchData(integer_ns));
|
||
ASSERT_TRUE(launch_data.get());
|
||
ASSERT_EQ(LaunchDataGetType(launch_data.get()), LAUNCH_DATA_INTEGER);
|
||
EXPECT_EQ(LaunchDataGetInteger(launch_data.get()),
|
||
[integer_ns longLongValue])
|
||
<< "index " << index;
|
||
}
|
||
}
|
||
}
|
||
|
||
TEST(Launchd, CFPropertyToLaunchData_FloatingPoint) {
|
||
@autoreleasepool {
|
||
base::mac::ScopedLaunchData launch_data;
|
||
|
||
NSNumber* double_nses[] = {
|
||
@0.0,
|
||
@1.0,
|
||
@-1.0,
|
||
[NSNumber numberWithFloat:std::numeric_limits<float>::min()],
|
||
[NSNumber numberWithFloat:std::numeric_limits<float>::max()],
|
||
[NSNumber numberWithDouble:std::numeric_limits<double>::min()],
|
||
[NSNumber numberWithDouble:std::numeric_limits<double>::max()],
|
||
@3.1415926535897932,
|
||
[NSNumber numberWithDouble:std::numeric_limits<double>::infinity()],
|
||
[NSNumber numberWithDouble:std::numeric_limits<double>::quiet_NaN()],
|
||
[NSNumber numberWithDouble:std::numeric_limits<double>::signaling_NaN()],
|
||
};
|
||
|
||
for (size_t index = 0; index < arraysize(double_nses); ++index) {
|
||
NSNumber* double_ns = double_nses[index];
|
||
launch_data.reset(CFPropertyToLaunchData(double_ns));
|
||
ASSERT_TRUE(launch_data.get());
|
||
ASSERT_EQ(LaunchDataGetType(launch_data.get()), LAUNCH_DATA_REAL);
|
||
double expected_double_value = [double_ns doubleValue];
|
||
double observed_double_value = LaunchDataGetReal(launch_data.get());
|
||
bool expected_is_nan = std::isnan(expected_double_value);
|
||
EXPECT_EQ(std::isnan(observed_double_value), expected_is_nan);
|
||
if (!expected_is_nan) {
|
||
EXPECT_DOUBLE_EQ(expected_double_value, observed_double_value)
|
||
<< "index " << index;
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
TEST(Launchd, CFPropertyToLaunchData_Boolean) {
|
||
@autoreleasepool {
|
||
base::mac::ScopedLaunchData launch_data;
|
||
|
||
NSNumber* bool_nses[] = {
|
||
@NO,
|
||
@YES,
|
||
};
|
||
|
||
for (size_t index = 0; index < arraysize(bool_nses); ++index) {
|
||
NSNumber* bool_ns = bool_nses[index];
|
||
launch_data.reset(CFPropertyToLaunchData(bool_ns));
|
||
ASSERT_TRUE(launch_data.get());
|
||
ASSERT_EQ(LaunchDataGetType(launch_data.get()), LAUNCH_DATA_BOOL);
|
||
if ([bool_ns boolValue]) {
|
||
EXPECT_TRUE(LaunchDataGetBool(launch_data.get()));
|
||
} else {
|
||
EXPECT_FALSE(LaunchDataGetBool(launch_data.get()));
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
TEST(Launchd, CFPropertyToLaunchData_String) {
|
||
@autoreleasepool {
|
||
base::mac::ScopedLaunchData launch_data;
|
||
|
||
NSString* string_nses[] = {
|
||
@"",
|
||
@"string",
|
||
@"Üñîçø∂é",
|
||
};
|
||
|
||
for (size_t index = 0; index < arraysize(string_nses); ++index) {
|
||
NSString* string_ns = string_nses[index];
|
||
launch_data.reset(CFPropertyToLaunchData(string_ns));
|
||
ASSERT_TRUE(launch_data.get());
|
||
ASSERT_EQ(LaunchDataGetType(launch_data.get()), LAUNCH_DATA_STRING);
|
||
EXPECT_STREQ([string_ns UTF8String],
|
||
LaunchDataGetString(launch_data.get()));
|
||
}
|
||
}
|
||
}
|
||
|
||
TEST(Launchd, CFPropertyToLaunchData_Data) {
|
||
@autoreleasepool {
|
||
base::mac::ScopedLaunchData launch_data;
|
||
|
||
const uint8_t data_c[] = {
|
||
1, 2, 3, 4, 5, 6, 7, 8, 0, 0, 0, 0, 0, 0, 0, 0, 9, 8, 7, 6, 5, 4, 3, 2};
|
||
NSData* data_ns = [NSData dataWithBytes:data_c length:sizeof(data_c)];
|
||
launch_data.reset(CFPropertyToLaunchData(data_ns));
|
||
ASSERT_TRUE(launch_data.get());
|
||
ASSERT_EQ(LaunchDataGetType(launch_data.get()), LAUNCH_DATA_OPAQUE);
|
||
EXPECT_EQ(LaunchDataGetOpaqueSize(launch_data.get()), sizeof(data_c));
|
||
EXPECT_EQ(
|
||
memcmp(LaunchDataGetOpaque(launch_data.get()), data_c, sizeof(data_c)),
|
||
0);
|
||
}
|
||
}
|
||
|
||
TEST(Launchd, CFPropertyToLaunchData_Dictionary) {
|
||
@autoreleasepool {
|
||
base::mac::ScopedLaunchData launch_data;
|
||
|
||
NSDictionary* dictionary_ns = @{
|
||
@"key" : @"value",
|
||
};
|
||
|
||
launch_data.reset(CFPropertyToLaunchData(dictionary_ns));
|
||
ASSERT_TRUE(launch_data.get());
|
||
ASSERT_EQ(LaunchDataGetType(launch_data.get()), LAUNCH_DATA_DICTIONARY);
|
||
EXPECT_EQ(LaunchDataDictGetCount(launch_data.get()), [dictionary_ns count]);
|
||
|
||
launch_data_t launch_lookup_data =
|
||
LaunchDataDictLookup(launch_data.get(), "key");
|
||
ASSERT_TRUE(launch_lookup_data);
|
||
ASSERT_EQ(LaunchDataGetType(launch_lookup_data), LAUNCH_DATA_STRING);
|
||
EXPECT_STREQ("value", LaunchDataGetString(launch_lookup_data));
|
||
}
|
||
}
|
||
|
||
TEST(Launchd, CFPropertyToLaunchData_Array) {
|
||
@autoreleasepool {
|
||
base::mac::ScopedLaunchData launch_data;
|
||
|
||
NSArray* array_ns = @[ @"element_1", @"element_2", ];
|
||
|
||
launch_data.reset(CFPropertyToLaunchData(array_ns));
|
||
ASSERT_TRUE(launch_data.get());
|
||
ASSERT_EQ(LaunchDataGetType(launch_data.get()), LAUNCH_DATA_ARRAY);
|
||
EXPECT_EQ(LaunchDataArrayGetCount(launch_data.get()), [array_ns count]);
|
||
|
||
launch_data_t launch_lookup_data =
|
||
LaunchDataArrayGetIndex(launch_data.get(), 0);
|
||
ASSERT_TRUE(launch_lookup_data);
|
||
ASSERT_EQ(LaunchDataGetType(launch_lookup_data), LAUNCH_DATA_STRING);
|
||
EXPECT_STREQ("element_1", LaunchDataGetString(launch_lookup_data));
|
||
|
||
launch_lookup_data = LaunchDataArrayGetIndex(launch_data.get(), 1);
|
||
ASSERT_TRUE(launch_lookup_data);
|
||
ASSERT_EQ(LaunchDataGetType(launch_lookup_data), LAUNCH_DATA_STRING);
|
||
EXPECT_STREQ("element_2", LaunchDataGetString(launch_lookup_data));
|
||
}
|
||
}
|
||
|
||
TEST(Launchd, CFPropertyToLaunchData_NSDate) {
|
||
// Test that NSDate conversions fail as advertised. There’s no type for
|
||
// storing date values in a launch_data_t.
|
||
|
||
@autoreleasepool {
|
||
base::mac::ScopedLaunchData launch_data;
|
||
|
||
NSDate* date = [NSDate date];
|
||
launch_data.reset(CFPropertyToLaunchData(date));
|
||
EXPECT_FALSE(launch_data.get());
|
||
|
||
NSDictionary* date_dictionary = @{
|
||
@"key" : @"value",
|
||
@"date" : date,
|
||
};
|
||
launch_data.reset(CFPropertyToLaunchData(date_dictionary));
|
||
EXPECT_FALSE(launch_data.get());
|
||
|
||
NSArray* date_array = @[ @"string_1", date, @"string_2", ];
|
||
launch_data.reset(CFPropertyToLaunchData(date_array));
|
||
EXPECT_FALSE(launch_data.get());
|
||
}
|
||
}
|
||
|
||
TEST(Launchd, CFPropertyToLaunchData_RealWorldJobDictionary) {
|
||
@autoreleasepool {
|
||
base::mac::ScopedLaunchData launch_data;
|
||
|
||
NSDictionary* job_dictionary = @{
|
||
@LAUNCH_JOBKEY_LABEL : @"com.example.job.rebooter",
|
||
@LAUNCH_JOBKEY_ONDEMAND : @YES,
|
||
@LAUNCH_JOBKEY_PROGRAMARGUMENTS :
|
||
@[ @"/bin/bash", @"-c", @"/sbin/reboot", ],
|
||
@LAUNCH_JOBKEY_MACHSERVICES : @{
|
||
@"com.example.service.rebooter" : @YES,
|
||
},
|
||
};
|
||
|
||
launch_data.reset(CFPropertyToLaunchData(job_dictionary));
|
||
ASSERT_TRUE(launch_data.get());
|
||
ASSERT_EQ(LaunchDataGetType(launch_data.get()), LAUNCH_DATA_DICTIONARY);
|
||
EXPECT_EQ(LaunchDataDictGetCount(launch_data.get()), 4u);
|
||
|
||
launch_data_t launch_lookup_data =
|
||
LaunchDataDictLookup(launch_data.get(), LAUNCH_JOBKEY_LABEL);
|
||
ASSERT_TRUE(launch_lookup_data);
|
||
ASSERT_EQ(LaunchDataGetType(launch_lookup_data), LAUNCH_DATA_STRING);
|
||
EXPECT_STREQ("com.example.job.rebooter",
|
||
LaunchDataGetString(launch_lookup_data));
|
||
|
||
launch_lookup_data =
|
||
LaunchDataDictLookup(launch_data.get(), LAUNCH_JOBKEY_ONDEMAND);
|
||
ASSERT_TRUE(launch_lookup_data);
|
||
ASSERT_EQ(LaunchDataGetType(launch_lookup_data), LAUNCH_DATA_BOOL);
|
||
EXPECT_TRUE(LaunchDataGetBool(launch_lookup_data));
|
||
|
||
launch_lookup_data =
|
||
LaunchDataDictLookup(launch_data.get(), LAUNCH_JOBKEY_PROGRAMARGUMENTS);
|
||
ASSERT_TRUE(launch_lookup_data);
|
||
ASSERT_EQ(LaunchDataGetType(launch_lookup_data), LAUNCH_DATA_ARRAY);
|
||
EXPECT_EQ(LaunchDataArrayGetCount(launch_lookup_data), 3u);
|
||
|
||
launch_data_t launch_sublookup_data =
|
||
LaunchDataArrayGetIndex(launch_lookup_data, 0);
|
||
ASSERT_TRUE(launch_sublookup_data);
|
||
ASSERT_EQ(LaunchDataGetType(launch_sublookup_data), LAUNCH_DATA_STRING);
|
||
EXPECT_STREQ("/bin/bash", LaunchDataGetString(launch_sublookup_data));
|
||
|
||
launch_sublookup_data = LaunchDataArrayGetIndex(launch_lookup_data, 1);
|
||
ASSERT_TRUE(launch_sublookup_data);
|
||
ASSERT_EQ(LaunchDataGetType(launch_sublookup_data), LAUNCH_DATA_STRING);
|
||
EXPECT_STREQ("-c", LaunchDataGetString(launch_sublookup_data));
|
||
|
||
launch_sublookup_data = LaunchDataArrayGetIndex(launch_lookup_data, 2);
|
||
ASSERT_TRUE(launch_sublookup_data);
|
||
ASSERT_EQ(LaunchDataGetType(launch_sublookup_data), LAUNCH_DATA_STRING);
|
||
EXPECT_STREQ("/sbin/reboot", LaunchDataGetString(launch_sublookup_data));
|
||
|
||
launch_lookup_data =
|
||
LaunchDataDictLookup(launch_data.get(), LAUNCH_JOBKEY_MACHSERVICES);
|
||
ASSERT_TRUE(launch_lookup_data);
|
||
ASSERT_EQ(LaunchDataGetType(launch_lookup_data), LAUNCH_DATA_DICTIONARY);
|
||
EXPECT_EQ(LaunchDataDictGetCount(launch_lookup_data), 1u);
|
||
|
||
launch_sublookup_data = LaunchDataDictLookup(
|
||
launch_lookup_data, "com.example.service.rebooter");
|
||
ASSERT_TRUE(launch_sublookup_data);
|
||
ASSERT_EQ(LaunchDataGetType(launch_sublookup_data), LAUNCH_DATA_BOOL);
|
||
EXPECT_TRUE(LaunchDataGetBool(launch_sublookup_data));
|
||
}
|
||
}
|
||
|
||
} // namespace
|
||
} // namespace test
|
||
} // namespace crashpad
|