mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 00:32:35 +08:00
2fb4e9e6a4
macOS 10.15 (“Catalina”) introduces a single new field to its dyld_all_image_infos structure, and uses structure version 16. macOS 10.13 and 10.14 were documented in <mach-o/dyld_images.h> as using structure version 16, but they actually use version 15. They should have used version 16, as they do use a structure expanded from macOS 10.12, which also uses version 15. Previously, process_types was true to the documentation, but now that this is known to be incorrect, it’s been revised to reflect reality. Because two variants of the version 15 structure exist, run-time OS version detection is used to disambiguate. Bug: crashpad:310 Test: crashpad_snapshot_test ProcessTypes.DyldImagesSelf (10.15 SDK) Change-Id: Ibc82b6a73809949f4bbf416ece7aa955b627c573 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1852109 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org>