mirror of
https://github.com/chromium/crashpad.git
synced 2025-01-14 09:17:57 +08:00
b2fd7d5307
When code raises an Objective-C exception, unwind the stack looking for any exception handlers. If an exception handler is encountered, test to see if it is a function known to be a catch-and-rethrow 'sinkhole' exception handler. Various routines in UIKit and elsewhere do this, and they obscure the exception stack, since the original throw location is no longer present on the stack (just the re-throw) when Crashpad captures the crash report. In the case of sinkholes, trigger an immediate exception to capture the original stack. The is an improvement over the alternative, NSSetUncaughtExceptionHandler, which passes along the stack frames, but not the stack memory contents and full exception context itself. The details of what happens after a fatal exception is triggered are unresolved in this CL. For now, simply call std::terminate. This code was inspired by chromium/src/chrome/browser/mac/ exception_processor.mm. Bug: crashpad:31 Change-Id: Ieebc6476a0507c466c8219c10f790ec0a624e58c Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2125254 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>