crashpad

mirror of https://github.com/chromium/crashpad.git synced 2025-03-20 02:23:47 +00:00

History

Ben Hamilton 1cf99ea4d2 [Crashpad/iOS] Harden CrashHandler against crashes during intermediate dump processing

https://crrev.com/c/3399252 fixed a heap overrun in iOS intermediate
dump processing.

This is a follow-up to that change to harden `CrashHandler` against
similar crashes:

1) Ensure the destructor of `ScopedAlternateWriter` is invoked
   to restore `InProcessHandler::writer_` state before processing
   the intermediate dump (otherwise, a signal raised by the intermediate
   dump handler would dereference the empty `std::unique_ptr` in
   `InProcessHandler::writer_`).

2) Harden `InProcessHandler` to check if `writer_` is empty before
   handling signals or exceptions

Change-Id: I1e63a496395b26681632302e8915b4433897037a
Bug: 391
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3401766
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>

2022-01-20 19:13:46 +00:00

exception_processor_test.mm

ios: Move and update ObjcExceptionPreprocessor.

2021-08-11 16:41:53 +00:00

exception_processor.h

ios: Move and update ObjcExceptionPreprocessor.

2021-08-11 16:41:53 +00:00

exception_processor.mm

ios: Use _LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS for backwards compatibility.

2021-12-01 02:24:06 +00:00

in_process_handler_test.cc

ios: Add IOSIntermediateDumpInterface.