mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-30 01:06:56 +08:00
d5ddd14ee1
Add MapInsertOrReplace<>() to insert a key-value pair into a map if the key is not already present, or replace the existing value for key if the key is present. The original value can optionally be returned to the caller in this case. Map insertions now use either MapInsertOrReplace<>() or std::map<>::insert() directly. Use MapInsertOrReplace<>() when the map should be updated to contain a mapping from a key to a value regardless of whether the key is already present. Use std::map<>::insert() to insert a mapping from a key to a value without replacing any existing mapping from a key, if present. If it is important to know whether an existing mapping from a key was present, use the returned std::pair<>.second. If it is important to know the existing value, use the returned std::pair<>.first->second. This change has a slight positive impact on performance. TEST=crashpad_util_test MapInsert.MapInsertOrReplace and others BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1044273002
68 lines
2.5 KiB
C++
68 lines
2.5 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#include "minidump/minidump_thread_id_map.h"
|
||
|
||
#include <limits>
|
||
#include <set>
|
||
#include <utility>
|
||
|
||
#include "base/logging.h"
|
||
#include "base/numerics/safe_conversions.h"
|
||
#include "snapshot/thread_snapshot.h"
|
||
|
||
namespace crashpad {
|
||
|
||
void BuildMinidumpThreadIDMap(
|
||
const std::vector<const ThreadSnapshot*>& thread_snapshots,
|
||
MinidumpThreadIDMap* thread_id_map) {
|
||
DCHECK(thread_id_map->empty());
|
||
|
||
// First, try truncating each 64-bit thread ID to 32 bits. If that’s possible
|
||
// for each unique 64-bit thread ID, then this will be used as the mapping.
|
||
// This preserves as much of the original thread ID as possible when feasible.
|
||
bool collision = false;
|
||
std::set<uint32_t> thread_ids_32;
|
||
for (const ThreadSnapshot* thread_snapshot : thread_snapshots) {
|
||
uint64_t thread_id_64 = thread_snapshot->ThreadID();
|
||
if (thread_id_map->find(thread_id_64) == thread_id_map->end()) {
|
||
uint32_t thread_id_32 = static_cast<uint32_t>(thread_id_64);
|
||
if (!thread_ids_32.insert(thread_id_32).second) {
|
||
collision = true;
|
||
break;
|
||
}
|
||
thread_id_map->insert(std::make_pair(thread_id_64, thread_id_32));
|
||
}
|
||
}
|
||
|
||
if (collision) {
|
||
// Since there was a collision, go back and assign each unique 64-bit thread
|
||
// ID its own sequential 32-bit equivalent. The 32-bit thread IDs will not
|
||
// bear any resemblance to the original 64-bit thread IDs.
|
||
thread_id_map->clear();
|
||
for (const ThreadSnapshot* thread_snapshot : thread_snapshots) {
|
||
uint64_t thread_id_64 = thread_snapshot->ThreadID();
|
||
if (thread_id_map->find(thread_id_64) == thread_id_map->end()) {
|
||
uint32_t thread_id_32 =
|
||
base::checked_cast<uint32_t>(thread_id_map->size());
|
||
thread_id_map->insert(std::make_pair(thread_id_64, thread_id_32));
|
||
}
|
||
}
|
||
|
||
DCHECK_LE(thread_id_map->size(), std::numeric_limits<uint32_t>::max());
|
||
}
|
||
}
|
||
|
||
} // namespace crashpad
|