mirror of https://github.com/chromium/crashpad.git synced 2024-12-29 00:32:35 +08:00

Go to file

Mark Mentovai aff8d906b6 linux: Fix interpretation of device numbers in /proc/pid/maps

While the kernel formats device major and minor numbers as %02x:%02x,
they are not restricted to 8 bits apiece. Crashpad was requiring that
the hexadecimal representations be exactly two characters, rather than
at least two characters.

The proper way to reconstruct a dev_t from major and minor numbers in
user space is to use makedev() from <sys/sysmacros.h>. MKDEV() from
<linux/kdev_t.h> interfaces with an older (pre-Linux 2.6) format which
actually did use 8-bit major and minor numbers. makedev() places the
major number at bits 8-19, and splits the minor number into two groups
at bits 0-7 and 20-31. This is the correct user space view of device
numbers. (Note that this is distinct from the kernel’s view: the kernel
uses MKDEV() from a distinct internal <linux/kdev_t.h> which places the
minor number at bits 0-19 and the major number at bits 20-31.)

Bionic for 32-bit platforms uses a 32-bit user space dev_t while a
64-bit version is used elsewhere, and a comment in Bionic’s
<sys/types.h> calls this a “historical accident”. However, due to the
kernel’s use of only 32 bits for device numbers, this accident does not
have any ill effect.

Bug: crashpad:30
Test: crashpad_util_test, crashpad_snapshot_test
Change-Id: Ic343454393d7399f598f9eba169a9e5f5630e601
Reviewed-on: https://chromium-review.googlesource.com/733863
Reviewed-by: Joshua Peraza <jperaza@chromium.org>

2017-10-23 20:11:37 +00:00

build

Switch the language standard to C++14 and use std::make_unique

2017-10-12 19:07:13 +00:00

client

C++14 is required, don’t pretend to support pre-C++11 or pre-MSVS 2015

2017-10-13 15:49:59 +00:00

compat

C++14 is required, don’t pretend to support pre-C++11 or pre-MSVS 2015

2017-10-13 15:49:59 +00:00

doc

doc: Update for NDK r15b