mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-09 14:06:33 +00:00
afc177ee21
Solves two problems with having the macros inline: 1. Deduplicates some of the logic (in this case, the name of the histogram, and whether it should be divided by 1024); 2. More useful check for compilation. As the macros are no-ops in Crashpad, it was easy to use the wrong name for a variable in the arguments to the macros (see .mm!) This way, we have some better chance of at least having code that compiles when built in Chromium if all the arguments are passed to Metrics::Something() in a standalone build. Also rolls mini_chromium DEPS to include: 99213eb Mark histogram arguments as unused to avoid warnings R=mark@chromium.org BUG=crashpad:100 Change-Id: I9f7fc3b85854fd61c1ebdf0084d728a7b690c2f1 Reviewed-on: https://chromium-review.googlesource.com/380445 Reviewed-by: Mark Mentovai <mark@chromium.org>