mirror of https://github.com/chromium/crashpad.git synced 2024-12-27 15:32:10 +08:00

Go to file

Mark Mentovai af594c8deb Heap-allocate MinidumpContextAMD64Writer objects with proper alignment

While making crashpad_minidump_test run in Chromium’s try- and buildbots
(https://crbug.com/779790), crashes in the
MinidumpThreadWriter.OneThread_AMD64_Stack test were observed in 32-bit
x86 Windows builds produced by Clang in the release configuration. These
crashes occurred in crashpad::test::InitializeMinidumpContextAMD64,
which heap-allocates a MinidumpContextAMD64Writer object. These objects
have an alignment requirement of 16, based on the alignment requirement
of their MinidumpContextAMD64 member.

Although this problem was never observed with MSVC, Clang was making use
of the known strict alignment and producing code that depended on it.
This code crashed if the requirement was not met. MSVC had raised a
warning about this usage (C4316), but the warning was disabled as it did
not appear to have any ill effect on code produced by that compiler.

The problem surfaced in test code, but heap-allocated
MinidumpContextAMD64Writer objects are created in non-test code as well.
The impact is limited, because a 32-bit Windows Crashpad handler would
not have a need to allocate one of these objects.

As a fix, MinidumpContextAMD64Writer is given a custom allocation
function (a static “operator new()” member and matching “operator
delete()”) that returns properly aligned memory.

Change-Id: I0cb924da91716eb01b88ec2ae952a69262cc2de6
Reviewed-on: https://chromium-review.googlesource.com/746539
Reviewed-by: Leonard Mosescu <mosescu@chromium.org>

2017-11-01 16:40:58 +00:00

build

win: Dynamically disable WoW64 tests absent explicit 32-bit build output

2017-10-26 18:31:57 +00:00

client

#include "build/build_config.h" where needed

2017-10-27 18:22:29 +00:00

compat

win: Expect uneven symbolic link support

2017-10-26 23:01:14 +00:00

doc

doc: Update for NDK r15b