crashpad/client/crashpad_client_ios_test.mm
Justin Cohen 3c4e37178d ios: Fix up concurrency in DumpWithoutCrashing and exception handling.
Change signal, uncaught NSExceptions and Mach exception handlers to
prevent re-entrancy with a first-exception-wins approach to prevent
concurrent exceptions from trying to use the same cached intermediate
dump writer.  Uses compare-and-swap to either return early for reentrant
signals or to wait indefinitely for anything after the first fatal
exception.

Change the NSException handler generated from the Objective-C exception
preprocessor to not used the cached intermediate dump writer and
not use the same first-exception-wins logic. This is useful because the
Objective-C exception preprocessor is imperfect and may generate
intermediate dumps that are not followed by process termination.

Simplify DumpWithoutCrashing's ownership of its intermediate dump writer
to be thread safe.

Set a handler for SIGPIPE for applications that haven't already
ignored or set a handler for SIGPIPE.

Bug: crashpad:391
Change-Id: Ia8ae61d50be81910fa0af40325300441d9dc01b6
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3401563
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
2022-03-10 18:05:16 +00:00

155 lines
4.8 KiB
Plaintext

// Copyright 2020 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "client/crashpad_client.h"
#import <Foundation/Foundation.h>
#include <vector>
#include "base/strings/sys_string_conversions.h"
#include "client/crash_report_database.h"
#include "client/ios_handler/exception_processor.h"
#include "client/simulate_crash.h"
#include "gtest/gtest.h"
#include "test/scoped_temp_dir.h"
#include "testing/platform_test.h"
#include "util/thread/thread.h"
namespace crashpad {
namespace test {
namespace {
class CrashpadIOSClient : public PlatformTest {
protected:
// testing::Test:
void SetUp() override {
ASSERT_TRUE(client_.StartCrashpadInProcessHandler(
base::FilePath(database_dir.path()), "", {}));
database_ = CrashReportDatabase::Initialize(database_dir.path());
}
void TearDown() override { client_.ResetForTesting(); }
auto& Client() { return client_; }
auto& Database() { return database_; }
private:
std::unique_ptr<CrashReportDatabase> database_;
CrashpadClient client_;
ScopedTempDir database_dir;
};
TEST_F(CrashpadIOSClient, DumpWithoutCrash) {
std::vector<CrashReportDatabase::Report> reports;
EXPECT_EQ(Database()->GetPendingReports(&reports),
CrashReportDatabase::kNoError);
ASSERT_EQ(reports.size(), 0u);
CRASHPAD_SIMULATE_CRASH();
EXPECT_EQ(Database()->GetPendingReports(&reports),
CrashReportDatabase::kNoError);
ASSERT_EQ(reports.size(), 1u);
}
TEST_F(CrashpadIOSClient, DumpWithoutCrashAndDefer) {
std::vector<CrashReportDatabase::Report> reports;
CRASHPAD_SIMULATE_CRASH_AND_DEFER_PROCESSING();
EXPECT_EQ(Database()->GetPendingReports(&reports),
CrashReportDatabase::kNoError);
ASSERT_EQ(reports.size(), 0u);
Client().ProcessIntermediateDumps();
EXPECT_EQ(Database()->GetPendingReports(&reports),
CrashReportDatabase::kNoError);
ASSERT_EQ(reports.size(), 1u);
}
TEST_F(CrashpadIOSClient, DumpWithoutCrashAndDeferAtPath) {
std::vector<CrashReportDatabase::Report> reports;
ScopedTempDir crash_dir;
UUID uuid;
uuid.InitializeWithNew();
CRASHPAD_SIMULATE_CRASH_AND_DEFER_PROCESSING_AT_PATH(
crash_dir.path().Append(uuid.ToString()));
EXPECT_EQ(Database()->GetPendingReports(&reports),
CrashReportDatabase::kNoError);
ASSERT_EQ(reports.size(), 0u);
NSError* error = nil;
NSArray* paths = [[NSFileManager defaultManager]
contentsOfDirectoryAtPath:base::SysUTF8ToNSString(
crash_dir.path().value())
error:&error];
ASSERT_EQ([paths count], 1u);
Client().ProcessIntermediateDump(
crash_dir.path().Append([paths[0] fileSystemRepresentation]));
reports.clear();
EXPECT_EQ(Database()->GetPendingReports(&reports),
CrashReportDatabase::kNoError);
ASSERT_EQ(reports.size(), 1u);
}
class RaceThread : public Thread {
public:
explicit RaceThread() : Thread() {}
private:
void ThreadMain() override {
for (int i = 0; i < 10; ++i) {
CRASHPAD_SIMULATE_CRASH();
}
}
};
TEST_F(CrashpadIOSClient, MultipleThreadsSimulateCrash) {
RaceThread race_threads[2];
for (RaceThread& race_thread : race_threads) {
race_thread.Start();
}
for (int i = 0; i < 10; ++i) {
CRASHPAD_SIMULATE_CRASH();
}
for (RaceThread& race_thread : race_threads) {
race_thread.Join();
}
std::vector<CrashReportDatabase::Report> reports;
ASSERT_EQ(Database()->GetPendingReports(&reports),
CrashReportDatabase::kNoError);
EXPECT_EQ(reports.size(), 30u);
}
// This test is covered by a similar XCUITest, but for development purposes it's
// sometimes easier and faster to run in Google Test. However, there's no way
// to correctly run this in Google Test. Leave the test here, disabled, for use
// during development only.
TEST_F(CrashpadIOSClient, DISABLED_ThrowNSException) {
[NSException raise:@"GoogleTestNSException" format:@"ThrowException"];
}
// This test is covered by a similar XCUITest, but for development purposes it's
// sometimes easier and faster to run in Google Test. However, there's no way
// to correctly run this in Google Test. Leave the test here, disabled, for use
// during development only.
TEST_F(CrashpadIOSClient, DISABLED_ThrowException) {
std::vector<int> empty_vector;
empty_vector.at(42);
}
} // namespace
} // namespace test
} // namespace crashpad