mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-10 06:36:02 +00:00
922b5750c1
zx_task_suspend() now supports suspending processes. This is somewhat more reliable than suspending the constituent threads because after the call returns and the token is being held, any subsequently started threads will start in the the suspended state. However, because the suspend is asynchronous the threads of the process still need to be iterated to wait for them to assert ZX_THREAD_SUSPENDED (and that can and does still fail to happen for a number of reasons). So while improved, this class is still only best-effort. Additionally, as the version of ScopedTaskSuspend that took a thread wasn't being used, remove that. Bug: crashpad:269 Change-Id: Ifb3f8e0d780a5e22af33613f92a61d25459f5139 Reviewed-on: https://chromium-review.googlesource.com/c/1377201 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org>
44 lines
1.4 KiB
C++
44 lines
1.4 KiB
C++
// Copyright 2018 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/fuchsia/scoped_task_suspend.h"
|
|
|
|
#include <lib/zx/time.h>
|
|
|
|
#include <vector>
|
|
|
|
#include "base/fuchsia/fuchsia_logging.h"
|
|
#include "base/logging.h"
|
|
#include "util/fuchsia/koid_utilities.h"
|
|
|
|
namespace crashpad {
|
|
|
|
ScopedTaskSuspend::ScopedTaskSuspend(const zx::process& process) {
|
|
DCHECK_NE(process.get(), zx::process::self()->get());
|
|
|
|
zx_status_t status = process.suspend(&suspend_token_);
|
|
if (status != ZX_OK) {
|
|
ZX_LOG(ERROR, status) << "zx_task_suspend";
|
|
} else {
|
|
for (const auto& thread : GetThreadHandles(process)) {
|
|
zx_signals_t observed = 0u;
|
|
status = thread.wait_one(
|
|
ZX_THREAD_SUSPENDED, zx::deadline_after(zx::msec(50)), &observed);
|
|
ZX_LOG_IF(ERROR, status != ZX_OK, status) << "thread failed to suspend";
|
|
}
|
|
}
|
|
}
|
|
|
|
} // namespace crashpad
|