mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-28 07:48:14 +08:00
Mark Mentovai
a685942342
MachMessageServer: invert the request buffer allocation logic.
The existing implementation used the same logic as is found in mach_msg_server(), but that logic seems incorrect. When the caller wants to retry a mach_msg() receive of a too-large message that returns MACH_RCV_TOO_LARGE, there’s no harm in attempting the receive with a larger buffer initially. On the other hand, if the caller does not want to retry such mach_msg() receive attempts, it’s an indication that the caller is expecting to be intolerant of too-large messages, and there’s no need to attempt the receive with a buffer any larger than requested. TEST=util_test R=rsesek@chromium.org Review URL: https://codereview.chromium.org/753363003
Description
Languages
C++
92.6%
Objective-C++
2.5%
C
2%
Python
1.7%
Assembly
0.9%
Other
0.3%