mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-10 06:36:02 +00:00
bde5196af5
The ProcessMemorySanitized implementation only allows reads to a given process if it falls within a given whitelist of memory ranges. This ensures that 'sanitized' snapshots only allow reading memory that was explicitly allowed. Bug: crashpad:263, chromium:973167 Change-Id: I72712d7ea3cabfd49cc91ffbe563cb349e6fcfdb Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1752593 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Joshua Peraza <jperaza@chromium.org>
65 lines
2.1 KiB
C++
65 lines
2.1 KiB
C++
// Copyright 2019 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/process/process_memory_sanitized.h"
|
|
|
|
#include "gtest/gtest.h"
|
|
#include "test/process_type.h"
|
|
#include "util/misc/from_pointer_cast.h"
|
|
#include "util/process/process_memory_native.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
TEST(ProcessMemorySanitized, DenyOnEmptyWhitelist) {
|
|
ProcessMemoryNative memory;
|
|
ASSERT_TRUE(memory.Initialize(GetSelfProcess()));
|
|
|
|
char c = 42;
|
|
char out;
|
|
|
|
ProcessMemorySanitized san_null;
|
|
san_null.Initialize(&memory, nullptr);
|
|
EXPECT_FALSE(san_null.Read(FromPointerCast<VMAddress>(&c), 1, &out));
|
|
|
|
std::vector<std::pair<VMAddress, VMAddress>> whitelist;
|
|
ProcessMemorySanitized san_blank;
|
|
san_blank.Initialize(&memory, &whitelist);
|
|
EXPECT_FALSE(san_blank.Read(FromPointerCast<VMAddress>(&c), 1, &out));
|
|
}
|
|
|
|
TEST(ProcessMemorySanitized, WhitelistingWorks) {
|
|
ProcessMemoryNative memory;
|
|
ASSERT_TRUE(memory.Initialize(GetSelfProcess()));
|
|
|
|
char str[4] = "ABC";
|
|
char out[4];
|
|
|
|
std::vector<std::pair<VMAddress, VMAddress>> whitelist;
|
|
whitelist.push_back(std::make_pair(FromPointerCast<VMAddress>(str + 1),
|
|
FromPointerCast<VMAddress>(str + 2)));
|
|
|
|
ProcessMemorySanitized sanitized;
|
|
sanitized.Initialize(&memory, &whitelist);
|
|
|
|
EXPECT_FALSE(sanitized.Read(FromPointerCast<VMAddress>(str), 1, &out));
|
|
EXPECT_TRUE(sanitized.Read(FromPointerCast<VMAddress>(str + 1), 1, &out));
|
|
EXPECT_FALSE(sanitized.Read(FromPointerCast<VMAddress>(str + 2), 1, &out));
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|