mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 00:00:08 +08:00
4688351623
This supports the “double handler” or “double handler with low probability” models from https://crashpad.chromium.org/bug/143. For crashpad_handler to be become its own client, it needs access to its own executable path to pass to CrashpadClient::StartHandler(). This was formerly available in the test-only test::Paths::Executable(). Bring that function’s implementation to the non-test Paths::Executable() in util/misc, and rename test::Paths to test::TestPaths to avoid future confusion. test::TestPaths must still be used to access TestDataRoot(), which does not make any sense to non-test code. test::TestPaths::Executable() is retained for use by tests, which most likely prefer the fatal semantics of that function. Paths::Executable() is not fatal because for the purposes of implementing the double handler, a failure to locate the executable path (which may happen on some systems in deeply-nested directory hierarchies) shouldn’t cause the initial crashpad_handler to abort, even if it does prevent a second crashpad_handler from being started. Bug: crashpad:143 Test: crashpad_util_test Paths.*, crashpad_test_test TestPaths.* Change-Id: I9f75bf61839ce51e33c9f7c0d7031cebead6a156 Reviewed-on: https://chromium-review.googlesource.com/466346 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
41 lines
1.3 KiB
C++
41 lines
1.3 KiB
C++
// Copyright 2017 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef CRASHPAD_UTIL_PATHS_H_
|
|
#define CRASHPAD_UTIL_PATHS_H_
|
|
|
|
#include "base/files/file_path.h"
|
|
#include "base/macros.h"
|
|
|
|
namespace crashpad {
|
|
|
|
//! \brief Functions to obtain paths.
|
|
class Paths {
|
|
public:
|
|
//! \brief Obtains the pathname of the currently-running executable.
|
|
//!
|
|
//! \param[out] path The pathname of the currently-running executable.
|
|
//!
|
|
//! \return `true` on success. `false` on failure, with a message logged.
|
|
//!
|
|
//! \note In test code, use test::TestPaths::Executable() instead.
|
|
static bool Executable(base::FilePath* path);
|
|
|
|
DISALLOW_IMPLICIT_CONSTRUCTORS(Paths);
|
|
};
|
|
|
|
} // namespace crashpad
|
|
|
|
#endif // CRASHPAD_UTIL_TEST_PATHS_H_
|