mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 00:00:08 +08:00
9b6c69cbb5
Follows https://chromium-review.googlesource.com/c/374019/. Causes MinidumpMemoryListWriter to merge all overlapping ranges before writing the MINIDUMP_MEMORY_LIST. This is: 1) Necessary for the Google internal crash processor, which in some cases attempts to read the raw memory (displaying ASAN red zones), and aborts if there are any overlapping ranges in the minidump on load; 2) Necessary for new-ish versions of windbg (see bug 216 below). It is believed that this is a change in behavior in the tool that made dumps with overlapping ranges unreadable; 3) More efficient. The .dmp for crashy_program goes from 306K to 140K with this enabled. In Chrome minidumps where set_gather_indirectly_referenced_memory() is used (in practice this means Chrome Windows Beta, Dev, and Canary), the savings are expected to be substantial. Bug: crashpad:61, chromium:638370, crashpad:216 Change-Id: I969e1a52da555ceba59a727d933bfeef6787c7a5 Reviewed-on: https://chromium-review.googlesource.com/374539 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
153 lines
3.8 KiB
C++
153 lines
3.8 KiB
C++
// Copyright 2018 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "snapshot/memory_snapshot.h"
|
|
|
|
#include "base/macros.h"
|
|
#include "gtest/gtest.h"
|
|
#include "snapshot/test/test_memory_snapshot.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
TEST(DetermineMergedRange, NonOverlapping) {
|
|
TestMemorySnapshot a;
|
|
TestMemorySnapshot b;
|
|
a.SetAddress(0);
|
|
a.SetSize(100);
|
|
b.SetAddress(200);
|
|
b.SetSize(50);
|
|
CheckedRange<uint64_t, size_t> range(0, 0);
|
|
EXPECT_FALSE(DetermineMergedRange(&a, &b, &range));
|
|
EXPECT_FALSE(DetermineMergedRange(&b, &a, &range));
|
|
|
|
a.SetSize(199);
|
|
EXPECT_FALSE(DetermineMergedRange(&a, &b, &range));
|
|
}
|
|
|
|
TEST(DetermineMergedRange, Empty) {
|
|
TestMemorySnapshot a;
|
|
TestMemorySnapshot b;
|
|
a.SetAddress(100);
|
|
a.SetSize(0);
|
|
b.SetAddress(200);
|
|
b.SetSize(20);
|
|
|
|
CheckedRange<uint64_t, size_t> range(0, 0);
|
|
// Empty are invalid.
|
|
EXPECT_FALSE(DetermineMergedRange(&a, &b, &range));
|
|
EXPECT_FALSE(DetermineMergedRange(&b, &a, &range));
|
|
EXPECT_FALSE(DetermineMergedRange(&a, &a, &range));
|
|
}
|
|
|
|
TEST(DetermineMergedRange, Abutting) {
|
|
TestMemorySnapshot a;
|
|
TestMemorySnapshot b;
|
|
|
|
a.SetAddress(0);
|
|
a.SetSize(10);
|
|
b.SetAddress(10);
|
|
b.SetSize(20);
|
|
|
|
CheckedRange<uint64_t, size_t> range(0, 0);
|
|
EXPECT_TRUE(DetermineMergedRange(&a, &b, &range));
|
|
EXPECT_EQ(0u, range.base());
|
|
EXPECT_EQ(30u, range.size());
|
|
|
|
EXPECT_TRUE(DetermineMergedRange(&b, &a, &range));
|
|
EXPECT_EQ(0u, range.base());
|
|
EXPECT_EQ(30u, range.size());
|
|
}
|
|
|
|
TEST(DetermineMergedRange, TypicalOverlapping) {
|
|
TestMemorySnapshot a;
|
|
TestMemorySnapshot b;
|
|
|
|
a.SetAddress(10);
|
|
a.SetSize(100);
|
|
b.SetAddress(50);
|
|
b.SetSize(100);
|
|
|
|
CheckedRange<uint64_t, size_t> range(0, 0);
|
|
EXPECT_TRUE(DetermineMergedRange(&a, &b, &range));
|
|
EXPECT_EQ(10u, range.base());
|
|
EXPECT_EQ(140u, range.size());
|
|
|
|
EXPECT_TRUE(DetermineMergedRange(&b, &a, &range));
|
|
EXPECT_EQ(10u, range.base());
|
|
EXPECT_EQ(140u, range.size());
|
|
}
|
|
|
|
TEST(DetermineMergedRange, OneFullyInsideAnother) {
|
|
TestMemorySnapshot a;
|
|
TestMemorySnapshot b;
|
|
|
|
a.SetAddress(20);
|
|
a.SetSize(100);
|
|
b.SetAddress(5);
|
|
b.SetSize(200);
|
|
|
|
CheckedRange<uint64_t, size_t> range(0, 0);
|
|
EXPECT_TRUE(DetermineMergedRange(&a, &b, &range));
|
|
EXPECT_EQ(5u, range.base());
|
|
EXPECT_EQ(200u, range.size());
|
|
|
|
EXPECT_TRUE(DetermineMergedRange(&b, &a, &range));
|
|
EXPECT_EQ(5u, range.base());
|
|
EXPECT_EQ(200u, range.size());
|
|
}
|
|
|
|
TEST(DetermineMergedRange, SameStart) {
|
|
TestMemorySnapshot a;
|
|
TestMemorySnapshot b;
|
|
|
|
a.SetAddress(5);
|
|
a.SetSize(100);
|
|
b.SetAddress(5);
|
|
b.SetSize(50);
|
|
|
|
CheckedRange<uint64_t, size_t> range(0, 0);
|
|
EXPECT_TRUE(DetermineMergedRange(&a, &b, &range));
|
|
EXPECT_EQ(5u, range.base());
|
|
EXPECT_EQ(100u, range.size());
|
|
|
|
EXPECT_TRUE(DetermineMergedRange(&b, &a, &range));
|
|
EXPECT_EQ(5u, range.base());
|
|
EXPECT_EQ(100u, range.size());
|
|
}
|
|
|
|
TEST(DetermineMergedRange, SameEnd) {
|
|
TestMemorySnapshot a;
|
|
TestMemorySnapshot b;
|
|
|
|
a.SetAddress(5);
|
|
a.SetSize(100);
|
|
b.SetAddress(70);
|
|
b.SetSize(35);
|
|
|
|
CheckedRange<uint64_t, size_t> range(0, 0);
|
|
EXPECT_TRUE(DetermineMergedRange(&a, &b, &range));
|
|
EXPECT_EQ(5u, range.base());
|
|
EXPECT_EQ(100u, range.size());
|
|
|
|
EXPECT_TRUE(DetermineMergedRange(&b, &a, &range));
|
|
EXPECT_EQ(5u, range.base());
|
|
EXPECT_EQ(100u, range.size());
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|