mirror of
https://github.com/chromium/crashpad.git
synced 2025-03-12 16:22:46 +00:00
9086d25ce8
CrashReportExceptionHandler::CatchMachException() must always set a
valid new_state. Failing to do so appears to trigger corpse generation
on OS X 10.11. This is addressed by calling ExcServerCopyState().
Previously, this was not done for exceptions forwarded to the user
ReportCrash, under the apparent mistaken assumption that ReportCrash
would do it. However, ReportCrash is given copies of out-parameters like
new_state to explicitly prevent it from influencing Crashpad’s returned
state.
ExcServerSuccessfulReturnValue() must not return MACH_RCV_PORT_DIED for
an EXC_CRASH handler on OS X 10.11. This appears to trigger corpse
generation. This is addressed by always returning KERN_SUCCESS from
EXC_CRASH handlers on OS X 10.11.
This also adds generic EXC_CORPSE_NOTIFY support throughout Crashpad.
The crashpad_handler does not listen for this exception type, but it is
now possible to work with this exception type using tools like
exception_port_tool and catch_exception_tool.
BUG=crashpad:48
TEST=Crashes handled by crashpad_handler do not result in the generation
of reports in the root /Library/Logs/DiagnosticReports.
R=kerrnel@chromium.org, rsesek@chromium.org
Review URL: https://codereview.chromium.org/1305893010 .
137 lines
4.1 KiB
C++
137 lines
4.1 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/mach/mach_extensions.h"
|
|
|
|
#include "base/mac/scoped_mach_port.h"
|
|
#include "gtest/gtest.h"
|
|
#include "test/mac/mach_errors.h"
|
|
#include "util/mac/mac_util.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
TEST(MachExtensions, MachThreadSelf) {
|
|
base::mac::ScopedMachSendRight thread_self(mach_thread_self());
|
|
EXPECT_EQ(thread_self, MachThreadSelf());
|
|
}
|
|
|
|
TEST(MachExtensions, NewMachPort_Receive) {
|
|
base::mac::ScopedMachReceiveRight port(NewMachPort(MACH_PORT_RIGHT_RECEIVE));
|
|
ASSERT_NE(kMachPortNull, port);
|
|
|
|
mach_port_type_t type;
|
|
kern_return_t kr = mach_port_type(mach_task_self(), port, &type);
|
|
ASSERT_EQ(KERN_SUCCESS, kr) << MachErrorMessage(kr, "mach_port_get_type");
|
|
|
|
EXPECT_EQ(MACH_PORT_TYPE_RECEIVE, type);
|
|
}
|
|
|
|
TEST(MachExtensions, NewMachPort_PortSet) {
|
|
base::mac::ScopedMachPortSet port(NewMachPort(MACH_PORT_RIGHT_PORT_SET));
|
|
ASSERT_NE(kMachPortNull, port);
|
|
|
|
mach_port_type_t type;
|
|
kern_return_t kr = mach_port_type(mach_task_self(), port, &type);
|
|
ASSERT_EQ(KERN_SUCCESS, kr) << MachErrorMessage(kr, "mach_port_get_type");
|
|
|
|
EXPECT_EQ(MACH_PORT_TYPE_PORT_SET, type);
|
|
}
|
|
|
|
TEST(MachExtensions, NewMachPort_DeadName) {
|
|
base::mac::ScopedMachSendRight port(NewMachPort(MACH_PORT_RIGHT_DEAD_NAME));
|
|
ASSERT_NE(kMachPortNull, port);
|
|
|
|
mach_port_type_t type;
|
|
kern_return_t kr = mach_port_type(mach_task_self(), port, &type);
|
|
ASSERT_EQ(KERN_SUCCESS, kr) << MachErrorMessage(kr, "mach_port_get_type");
|
|
|
|
EXPECT_EQ(MACH_PORT_TYPE_DEAD_NAME, type);
|
|
}
|
|
|
|
const exception_mask_t kExcMaskBasic =
|
|
EXC_MASK_BAD_ACCESS |
|
|
EXC_MASK_BAD_INSTRUCTION |
|
|
EXC_MASK_ARITHMETIC |
|
|
EXC_MASK_EMULATION |
|
|
EXC_MASK_SOFTWARE |
|
|
EXC_MASK_BREAKPOINT |
|
|
EXC_MASK_SYSCALL |
|
|
EXC_MASK_MACH_SYSCALL |
|
|
EXC_MASK_RPC_ALERT;
|
|
|
|
TEST(MachExtensions, ExcMaskAll) {
|
|
const exception_mask_t exc_mask_all = ExcMaskAll();
|
|
EXPECT_EQ(kExcMaskBasic, exc_mask_all & kExcMaskBasic);
|
|
|
|
EXPECT_FALSE(exc_mask_all & EXC_MASK_CRASH);
|
|
EXPECT_FALSE(exc_mask_all & EXC_MASK_CORPSE_NOTIFY);
|
|
|
|
const int mac_os_x_minor_version = MacOSXMinorVersion();
|
|
if (mac_os_x_minor_version >= 8) {
|
|
EXPECT_TRUE(exc_mask_all & EXC_MASK_RESOURCE);
|
|
} else {
|
|
EXPECT_FALSE(exc_mask_all & EXC_MASK_RESOURCE);
|
|
}
|
|
|
|
if (mac_os_x_minor_version >= 9) {
|
|
EXPECT_TRUE(exc_mask_all & EXC_MASK_GUARD);
|
|
} else {
|
|
EXPECT_FALSE(exc_mask_all & EXC_MASK_GUARD);
|
|
}
|
|
|
|
// Bit 0 should not be set.
|
|
EXPECT_FALSE(ExcMaskAll() & 1);
|
|
|
|
// Every bit set in ExcMaskAll() must also be set in ExcMaskValid().
|
|
EXPECT_EQ(ExcMaskAll(), ExcMaskAll() & ExcMaskValid());
|
|
}
|
|
|
|
TEST(MachExtensions, ExcMaskValid) {
|
|
const exception_mask_t exc_mask_valid = ExcMaskValid();
|
|
EXPECT_EQ(kExcMaskBasic, exc_mask_valid & kExcMaskBasic);
|
|
|
|
EXPECT_TRUE(exc_mask_valid & EXC_MASK_CRASH);
|
|
|
|
const int mac_os_x_minor_version = MacOSXMinorVersion();
|
|
if (mac_os_x_minor_version >= 8) {
|
|
EXPECT_TRUE(exc_mask_valid & EXC_MASK_RESOURCE);
|
|
} else {
|
|
EXPECT_FALSE(exc_mask_valid & EXC_MASK_RESOURCE);
|
|
}
|
|
|
|
if (mac_os_x_minor_version >= 9) {
|
|
EXPECT_TRUE(exc_mask_valid & EXC_MASK_GUARD);
|
|
} else {
|
|
EXPECT_FALSE(exc_mask_valid & EXC_MASK_GUARD);
|
|
}
|
|
|
|
if (mac_os_x_minor_version >= 11) {
|
|
EXPECT_TRUE(exc_mask_valid & EXC_MASK_CORPSE_NOTIFY);
|
|
} else {
|
|
EXPECT_FALSE(exc_mask_valid & EXC_MASK_CORPSE_NOTIFY);
|
|
}
|
|
|
|
// Bit 0 should not be set.
|
|
EXPECT_FALSE(ExcMaskValid() & 1);
|
|
|
|
// There must be bits set in ExcMaskValid() that are not set in ExcMaskAll().
|
|
EXPECT_TRUE(ExcMaskValid() & ~ExcMaskAll());
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|