mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 08:39:44 +08:00
4b450c8137
gtest used to require (expected, actual) ordering for arguments to
EXPECT_EQ and ASSERT_EQ, and in failed test assertions would identify
each side as “expected” or “actual.” Tests in Crashpad adhered to this
traditional ordering. After a gtest change in February 2016, it is now
agnostic with respect to the order of these arguments.
This change mechanically updates all uses of these macros to (actual,
expected) by reversing them. This provides consistency with our use of
the logging CHECK_EQ and DCHECK_EQ macros, and makes for better
readability by ordinary native speakers. The rough (but working!)
conversion tool is
https://chromium-review.googlesource.com/c/466727/1/rewrite_expectassert_eq.py,
and “git cl format” cleaned up its output.
EXPECT_NE and ASSERT_NE never had a preferred ordering. gtest never made
a judgment that one side or the other needed to provide an “unexpected”
value. Consequently, some code used (unexpected, actual) while other
code used (actual, unexpected). For consistency with the new EXPECT_EQ
and ASSERT_EQ usage, as well as consistency with CHECK_NE and DCHECK_NE,
this change also updates these use sites to (actual, unexpected) where
one side can be called “unexpected” as, for example, std::string::npos
can be. Unfortunately, this portion was a manual conversion.
References:
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md#binary-comparison
77d6b17338
https://github.com/google/googletest/pull/713
Change-Id: I978fef7c94183b8b1ef63f12f5ab4d6693626be3
Reviewed-on: https://chromium-review.googlesource.com/466727
Reviewed-by: Scott Graham <scottmg@chromium.org>
194 lines
6.2 KiB
C++
194 lines
6.2 KiB
C++
// Copyright 2014 The Crashpad Authors. All rights reserved.
|
||
//
|
||
// Licensed under the Apache License, Version 2.0 (the "License");
|
||
// you may not use this file except in compliance with the License.
|
||
// You may obtain a copy of the License at
|
||
//
|
||
// http://www.apache.org/licenses/LICENSE-2.0
|
||
//
|
||
// Unless required by applicable law or agreed to in writing, software
|
||
// distributed under the License is distributed on an "AS IS" BASIS,
|
||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
// See the License for the specific language governing permissions and
|
||
// limitations under the License.
|
||
|
||
#include "util/posix/process_info.h"
|
||
|
||
#include <time.h>
|
||
|
||
#include <algorithm>
|
||
#include <set>
|
||
#include <string>
|
||
#include <vector>
|
||
|
||
#include "base/strings/stringprintf.h"
|
||
#include "build/build_config.h"
|
||
#include "gtest/gtest.h"
|
||
#include "test/errors.h"
|
||
#include "test/main_arguments.h"
|
||
#include "test/multiprocess.h"
|
||
#include "util/file/file_io.h"
|
||
#include "util/misc/implicit_cast.h"
|
||
|
||
namespace crashpad {
|
||
namespace test {
|
||
namespace {
|
||
|
||
void TestProcessSelfOrClone(const ProcessInfo& process_info) {
|
||
// There’s no system call to obtain the saved set-user ID or saved set-group
|
||
// ID in an easy way. Normally, they are the same as the effective user ID and
|
||
// effective group ID, so just check against those.
|
||
EXPECT_EQ(process_info.RealUserID(), getuid());
|
||
const uid_t euid = geteuid();
|
||
EXPECT_EQ(process_info.EffectiveUserID(), euid);
|
||
EXPECT_EQ(process_info.SavedUserID(), euid);
|
||
|
||
const gid_t gid = getgid();
|
||
EXPECT_EQ(process_info.RealGroupID(), gid);
|
||
const gid_t egid = getegid();
|
||
EXPECT_EQ(process_info.EffectiveGroupID(), egid);
|
||
EXPECT_EQ(process_info.SavedGroupID(), egid);
|
||
|
||
// Test SupplementaryGroups().
|
||
int group_count = getgroups(0, nullptr);
|
||
ASSERT_GE(group_count, 0) << ErrnoMessage("getgroups");
|
||
|
||
std::vector<gid_t> group_vector(group_count);
|
||
if (group_count > 0) {
|
||
group_count = getgroups(group_vector.size(), &group_vector[0]);
|
||
ASSERT_GE(group_count, 0) << ErrnoMessage("getgroups");
|
||
ASSERT_EQ(implicit_cast<size_t>(group_count), group_vector.size());
|
||
}
|
||
|
||
std::set<gid_t> group_set(group_vector.begin(), group_vector.end());
|
||
EXPECT_EQ(process_info.SupplementaryGroups(), group_set);
|
||
|
||
// Test AllGroups(), which is SupplementaryGroups() plus the real, effective,
|
||
// and saved set-group IDs. The effective and saved set-group IDs are expected
|
||
// to be identical (see above).
|
||
group_set.insert(gid);
|
||
group_set.insert(egid);
|
||
|
||
EXPECT_EQ(process_info.AllGroups(), group_set);
|
||
|
||
// The test executable isn’t expected to change privileges.
|
||
EXPECT_FALSE(process_info.DidChangePrivileges());
|
||
|
||
bool is_64_bit;
|
||
ASSERT_TRUE(process_info.Is64Bit(&is_64_bit));
|
||
#if defined(ARCH_CPU_64_BITS)
|
||
EXPECT_TRUE(is_64_bit);
|
||
#else
|
||
EXPECT_FALSE(is_64_bit);
|
||
#endif
|
||
|
||
// Test StartTime(). This program must have started at some time in the past.
|
||
timeval start_time;
|
||
ASSERT_TRUE(process_info.StartTime(&start_time));
|
||
EXPECT_FALSE(start_time.tv_sec == 0 && start_time.tv_usec == 0);
|
||
time_t now;
|
||
time(&now);
|
||
EXPECT_LE(start_time.tv_sec, now);
|
||
|
||
std::vector<std::string> argv;
|
||
ASSERT_TRUE(process_info.Arguments(&argv));
|
||
|
||
const std::vector<std::string>& expect_argv = GetMainArguments();
|
||
|
||
// expect_argv always contains the initial view of the arguments at the time
|
||
// the program was invoked. argv may contain this view, or it may contain the
|
||
// current view of arguments after gtest argv processing. argv may be a subset
|
||
// of expect_argv.
|
||
//
|
||
// gtest argv processing always leaves argv[0] intact, so this can be checked
|
||
// directly.
|
||
ASSERT_FALSE(expect_argv.empty());
|
||
ASSERT_FALSE(argv.empty());
|
||
EXPECT_EQ(argv[0], expect_argv[0]);
|
||
|
||
EXPECT_LE(argv.size(), expect_argv.size());
|
||
|
||
// Everything else in argv should have a match in expect_argv too, but things
|
||
// may have moved around.
|
||
for (size_t arg_index = 1; arg_index < argv.size(); ++arg_index) {
|
||
const std::string& arg = argv[arg_index];
|
||
SCOPED_TRACE(
|
||
base::StringPrintf("arg_index %zu, arg %s", arg_index, arg.c_str()));
|
||
EXPECT_NE(expect_argv.end(), std::find(argv.begin(), argv.end(), arg));
|
||
}
|
||
}
|
||
|
||
void TestSelfProcess(const ProcessInfo& process_info) {
|
||
EXPECT_EQ(process_info.ProcessID(), getpid());
|
||
EXPECT_EQ(process_info.ParentProcessID(), getppid());
|
||
|
||
TestProcessSelfOrClone(process_info);
|
||
}
|
||
|
||
TEST(ProcessInfo, Self) {
|
||
ProcessInfo process_info;
|
||
ASSERT_TRUE(process_info.Initialize(getpid()));
|
||
TestSelfProcess(process_info);
|
||
}
|
||
|
||
#if defined(OS_MACOSX)
|
||
TEST(ProcessInfo, SelfTask) {
|
||
ProcessInfo process_info;
|
||
ASSERT_TRUE(process_info.InitializeFromTask(mach_task_self()));
|
||
TestSelfProcess(process_info);
|
||
}
|
||
#endif
|
||
|
||
TEST(ProcessInfo, Pid1) {
|
||
// PID 1 is expected to be init or the system’s equivalent. This tests reading
|
||
// information about another process.
|
||
ProcessInfo process_info;
|
||
ASSERT_TRUE(process_info.Initialize(1));
|
||
|
||
EXPECT_EQ(process_info.ProcessID(), implicit_cast<pid_t>(1));
|
||
EXPECT_EQ(process_info.ParentProcessID(), implicit_cast<pid_t>(0));
|
||
EXPECT_EQ(process_info.RealUserID(), implicit_cast<uid_t>(0));
|
||
EXPECT_EQ(process_info.EffectiveUserID(), implicit_cast<uid_t>(0));
|
||
EXPECT_EQ(process_info.SavedUserID(), implicit_cast<uid_t>(0));
|
||
EXPECT_EQ(process_info.RealGroupID(), implicit_cast<gid_t>(0));
|
||
EXPECT_EQ(process_info.EffectiveGroupID(), implicit_cast<gid_t>(0));
|
||
EXPECT_EQ(process_info.SavedGroupID(), implicit_cast<gid_t>(0));
|
||
EXPECT_FALSE(process_info.AllGroups().empty());
|
||
}
|
||
|
||
class ProcessInfoForkedTest : public Multiprocess {
|
||
public:
|
||
ProcessInfoForkedTest() : Multiprocess() {}
|
||
~ProcessInfoForkedTest() {}
|
||
|
||
// Multiprocess:
|
||
void MultiprocessParent() override {
|
||
const pid_t pid = ChildPID();
|
||
|
||
ProcessInfo process_info;
|
||
ASSERT_TRUE(process_info.Initialize(pid));
|
||
|
||
EXPECT_EQ(process_info.ProcessID(), pid);
|
||
EXPECT_EQ(process_info.ParentProcessID(), getpid());
|
||
|
||
TestProcessSelfOrClone(process_info);
|
||
}
|
||
|
||
void MultiprocessChild() override {
|
||
// Hang around until the parent is done.
|
||
CheckedReadFileAtEOF(ReadPipeHandle());
|
||
}
|
||
|
||
private:
|
||
DISALLOW_COPY_AND_ASSIGN(ProcessInfoForkedTest);
|
||
};
|
||
|
||
TEST(ProcessInfo, Forked) {
|
||
ProcessInfoForkedTest test;
|
||
test.Run();
|
||
}
|
||
|
||
} // namespace
|
||
} // namespace test
|
||
} // namespace crashpad
|