mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-26 06:31:50 +08:00
9a5a789123
In 5412beb63386, I asserted (via my code) that the kern.osproductversion sysctl was introduced in 10.12.0, but this was utterly wrong. It’s not available until 10.13.4. Compare 10.13.3 xnu-4570.41.2/bsd/kern/kern_sysctl.c to 10.13.4 xnu-4570.51.1/bsd/kern/kern_sysctl.c, look for osproductversion. https://pbs.twimg.com/media/EU0GDTVU4AY73KC.jpg Failures appeared starting at https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/37499 (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8869605548532164608/+/steps/crashpad_tests_on_Intel_GPU_on_Mac_on_Mac-10.12.6/0/stdout). This fixes expectations to not require kern.osproductversion to exist until 10.13.4. VM-tested on 10.12.6, 10.13.3, 10.13.4, and 10.14.0. Bug: crashpad:347 Test: crashpad_util_test MacUtil.MacOSVersionNumber Change-Id: Ic58d8ca8f04394d41c691dd2d946c59497ee71d5 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2402248 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
