mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-30 01:06:56 +08:00
984749479f
Some of the new Linux/Android tests were failing in 32-bit code where pointers were being casted via reinterpret_cast<>() to LinuxVMAddress, an unsigned 64-bit type. The behavior of such casts is implementation-defined, and in this case, sign-extension was being used to convert the 32-bit pointers to 64 bits, resulting in very large (unsigned) LinuxVMAddress values that could not possibly refer to proper addresses in a 32-bit process’ address space. The offending reinterpret_cast<>() conversions have been replaced with the new FromPointerCast<>(), which is careful to do sign-extension when converting to a signed type, and zero-extension when converting to an unsigned type like LinuxVMAddress. Bug: crashpad:30 Test: crashpad_util_test FromPointerCast*:MemoryMap.*:ProcessMemory.* Change-Id: I6f1408dc63369a8740ecd6015d657e4407a7c271 Reviewed-on: https://chromium-review.googlesource.com/488264 Reviewed-by: Joshua Peraza <jperaza@chromium.org>
183 lines
6.0 KiB
Python
183 lines
6.0 KiB
Python
# Copyright 2014 The Crashpad Authors. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
{
|
|
'includes': [
|
|
'../build/crashpad.gypi',
|
|
],
|
|
'targets': [
|
|
{
|
|
'target_name': 'crashpad_util_test',
|
|
'type': 'executable',
|
|
'dependencies': [
|
|
'util.gyp:crashpad_util',
|
|
'../client/client.gyp:crashpad_client',
|
|
'../compat/compat.gyp:crashpad_compat',
|
|
'../test/test.gyp:crashpad_gmock_main',
|
|
'../test/test.gyp:crashpad_test',
|
|
'../third_party/gtest/gmock.gyp:gmock',
|
|
'../third_party/gtest/gtest.gyp:gtest',
|
|
'../third_party/mini_chromium/mini_chromium.gyp:base',
|
|
'../third_party/zlib/zlib.gyp:zlib',
|
|
],
|
|
'include_dirs': [
|
|
'..',
|
|
],
|
|
'sources': [
|
|
'file/delimited_file_reader_test.cc',
|
|
'file/file_io_test.cc',
|
|
'file/file_reader_test.cc',
|
|
'file/string_file_test.cc',
|
|
'linux/memory_map_test.cc',
|
|
'linux/process_memory_test.cc',
|
|
'linux/scoped_ptrace_attach_test.cc',
|
|
'mac/launchd_test.mm',
|
|
'mac/mac_util_test.mm',
|
|
'mac/service_management_test.mm',
|
|
'mac/xattr_test.cc',
|
|
'mach/child_port_handshake_test.cc',
|
|
'mach/child_port_server_test.cc',
|
|
'mach/composite_mach_message_server_test.cc',
|
|
'mach/exc_client_variants_test.cc',
|
|
'mach/exc_server_variants_test.cc',
|
|
'mach/exception_behaviors_test.cc',
|
|
'mach/exception_ports_test.cc',
|
|
'mach/exception_types_test.cc',
|
|
'mach/mach_extensions_test.cc',
|
|
'mach/mach_message_server_test.cc',
|
|
'mach/mach_message_test.cc',
|
|
'mach/notify_server_test.cc',
|
|
'mach/scoped_task_suspend_test.cc',
|
|
'mach/symbolic_constants_mach_test.cc',
|
|
'mach/task_memory_test.cc',
|
|
'misc/arraysize_unsafe_test.cc',
|
|
'misc/clock_test.cc',
|
|
'misc/from_pointer_cast_test.cc',
|
|
'misc/initialization_state_dcheck_test.cc',
|
|
'misc/initialization_state_test.cc',
|
|
'misc/paths_test.cc',
|
|
'misc/scoped_forbid_return_test.cc',
|
|
'misc/random_string_test.cc',
|
|
'misc/uuid_test.cc',
|
|
'net/http_body_gzip_test.cc',
|
|
'net/http_body_test.cc',
|
|
'net/http_body_test_util.cc',
|
|
'net/http_body_test_util.h',
|
|
'net/http_multipart_builder_test.cc',
|
|
'net/http_transport_test.cc',
|
|
'numeric/checked_address_range_test.cc',
|
|
'numeric/checked_range_test.cc',
|
|
'numeric/in_range_cast_test.cc',
|
|
'numeric/int128_test.cc',
|
|
'posix/process_info_test.cc',
|
|
'posix/scoped_mmap_test.cc',
|
|
'posix/signals_test.cc',
|
|
'posix/symbolic_constants_posix_test.cc',
|
|
'stdlib/aligned_allocator_test.cc',
|
|
'stdlib/map_insert_test.cc',
|
|
'stdlib/string_number_conversion_test.cc',
|
|
'stdlib/strlcpy_test.cc',
|
|
'stdlib/strnlen_test.cc',
|
|
'stdlib/thread_safe_vector_test.cc',
|
|
'string/split_string_test.cc',
|
|
'synchronization/semaphore_test.cc',
|
|
'thread/thread_log_messages_test.cc',
|
|
'thread/thread_test.cc',
|
|
'thread/worker_thread_test.cc',
|
|
'win/capture_context_test.cc',
|
|
'win/command_line_test.cc',
|
|
'win/critical_section_with_debug_info_test.cc',
|
|
'win/exception_handler_server_test.cc',
|
|
'win/get_function_test.cc',
|
|
'win/handle_test.cc',
|
|
'win/initial_client_data_test.cc',
|
|
'win/process_info_test.cc',
|
|
'win/registration_protocol_win_test.cc',
|
|
'win/safe_terminate_process_test.cc',
|
|
'win/scoped_process_suspend_test.cc',
|
|
'win/session_end_watcher_test.cc',
|
|
'win/time_test.cc',
|
|
],
|
|
'conditions': [
|
|
['OS=="mac"', {
|
|
'link_settings': {
|
|
'libraries': [
|
|
'$(SDKROOT)/System/Library/Frameworks/Foundation.framework',
|
|
],
|
|
},
|
|
}],
|
|
['OS=="win"', {
|
|
'dependencies': [
|
|
'crashpad_util_test_process_info_test_child',
|
|
'crashpad_util_test_safe_terminate_process_test_child',
|
|
],
|
|
'link_settings': {
|
|
'libraries': [
|
|
'-ladvapi32.lib',
|
|
'-limagehlp.lib',
|
|
'-lrpcrt4.lib',
|
|
'-luser32.lib',
|
|
],
|
|
},
|
|
}],
|
|
['OS=="android"', {
|
|
# Things not yet ported to Android
|
|
'sources/' : [
|
|
['exclude', '^net/http_transport_test\\.cc$'],
|
|
]
|
|
}],
|
|
],
|
|
'target_conditions': [
|
|
['OS=="android"', {
|
|
'sources/': [
|
|
['include', '^linux/'],
|
|
],
|
|
}],
|
|
],
|
|
},
|
|
],
|
|
'conditions': [
|
|
['OS=="win"', {
|
|
'targets': [
|
|
{
|
|
'target_name': 'crashpad_util_test_process_info_test_child',
|
|
'type': 'executable',
|
|
'sources': [
|
|
'win/process_info_test_child.cc',
|
|
],
|
|
# Set an unusually high load address to make sure that the main
|
|
# executable still appears as the first element in
|
|
# ProcessInfo::Modules().
|
|
'msvs_settings': {
|
|
'VCLinkerTool': {
|
|
'AdditionalOptions': [
|
|
'/BASE:0x78000000',
|
|
],
|
|
'RandomizedBaseAddress': '1', # /DYNAMICBASE:NO.
|
|
'FixedBaseAddress': '2', # /FIXED.
|
|
},
|
|
},
|
|
},
|
|
{
|
|
'target_name': 'crashpad_util_test_safe_terminate_process_test_child',
|
|
'type': 'executable',
|
|
'sources': [
|
|
'win/safe_terminate_process_test_child.cc',
|
|
],
|
|
},
|
|
]
|
|
}],
|
|
],
|
|
}
|