mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-28 07:48:14 +08:00
Mark Mentovai
94f7f9eeb2
MinidumpCrashpadInfo: the default constructor should zero-initialize.
This regressed in 359bdd86225c when a non-POD UUID data member was added to MinidumpCrashpadInfo, which made MinidumpCrashpadInfo non-POD. This problem seems to have affected MinidumpModuleCodeViewRecordPDB70 since it was added, but it is not likely to have caused any problems there because that structure never appears without having all of its members populated. By comparison, MinidumpCrashpadInfo may be sparsely populated. This caused 4 of the 5 MinidumpCrashpadInfoWriter tests to fail on Windows. TEST=crashpad_minidump_test MinidumpCrashpadInfoWriter.* R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1001683002
Description
Languages
C++
92.6%
Objective-C++
2.5%
C
2%
Python
1.7%
Assembly
0.9%
Other
0.3%