crashpad/test/multiprocess_posix.cc
Mark Mentovai 94a5a72efa mac: Tests that crash intentionally shouldn’t go to ReportCrash
Crashpad has many tests that crash intentionally. Some of these are
gtest death tests, and others arrange for intentional crashes to test
Crashpad’s own crash-catching logic. On macOS, all of the gtest death
tests and some of the other intentional crashes were being logged by
ReportCrash, the system’s crash reporter. Since these reports
corresponded to intentional crashes, they were never useful, and served
only to clutter ~/Library/Logs/DiagnosticReports.

Since Crashpad is adept at handling exceptions on its own, this
introduces the “exception swallowing server”,
crashpad_exception_swallower, which is a Mach exception server that
implements a no-op exception handler routine for all exceptions
received. The exception swallowing server is established as the task
handler for EXC_CRASH and EXC_CORPSE_NOTIFY exceptions during gtest
death tests invoked by {ASSERT,EXPECT}_DEATH_{CHECK,CRASH}, and for all
child processes invoked by the Multiprocess test infrastructure. The
exception swallowing server is not in effect at other times, so
unexpected crashes in test code can still be handled by ReportCrash or
another crash reporter.

With this change in place, no new reports are generated in the
user-level ~/Library/Logs/DiagnosticReports or the system’s
/Library/Logs/DiagnosticReports during a run of Crashpad’s full test
suite on macOS.

Bug: crashpad:33
Change-Id: I13891853a7e25accc30da21fa7ea8bd7d1f3bd2f
Reviewed-on: https://chromium-review.googlesource.com/777859
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
2017-11-20 18:58:34 +00:00

249 lines
6.9 KiB
C++
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

// Copyright 2014 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "test/multiprocess.h"
#include <signal.h>
#include <stdlib.h>
#include <sys/wait.h>
#include <unistd.h>
#include <memory>
#include <string>
#include "base/auto_reset.h"
#include "base/files/scoped_file.h"
#include "base/logging.h"
#include "base/posix/eintr_wrapper.h"
#include "base/strings/stringprintf.h"
#include "build/build_config.h"
#include "gtest/gtest.h"
#include "test/errors.h"
#include "util/misc/scoped_forbid_return.h"
#include "util/posix/signals.h"
#if defined(OS_MACOSX)
#include "test/mac/exception_swallower.h"
#endif
namespace crashpad {
namespace test {
namespace internal {
struct MultiprocessInfo {
MultiprocessInfo()
: pipe_c2p_read(-1),
pipe_c2p_write(-1),
pipe_p2c_read(-1),
pipe_p2c_write(-1),
child_pid(0) {}
base::ScopedFD pipe_c2p_read; // child to parent
base::ScopedFD pipe_c2p_write; // child to parent
base::ScopedFD pipe_p2c_read; // parent to child
base::ScopedFD pipe_p2c_write; // parent to child
pid_t child_pid; // valid only in parent
};
} // namespace internal
Multiprocess::Multiprocess()
: info_(nullptr),
code_(EXIT_SUCCESS),
reason_(kTerminationNormal) {
}
void Multiprocess::Run() {
ASSERT_EQ(info_, nullptr);
std::unique_ptr<internal::MultiprocessInfo> info(
new internal::MultiprocessInfo);
base::AutoReset<internal::MultiprocessInfo*> reset_info(&info_, info.get());
ASSERT_NO_FATAL_FAILURE(PreFork());
#if defined(OS_MACOSX)
// If the child is expected to crash, set up an exception swallower process
// to swallow the exception instead of allowing it to be seen by the systems
// crash reporter.
const bool swallow_exceptions =
reason_ == kTerminationSignal && Signals::IsCrashSignal(code_);
if (swallow_exceptions) {
ExceptionSwallower::Parent_PrepareForCrashingChild();
}
#endif // OS_MACOSX
pid_t pid = fork();
ASSERT_GE(pid, 0) << ErrnoMessage("fork");
if (pid > 0) {
info_->child_pid = pid;
RunParent();
// Waiting for the child happens here instead of in RunParent() because even
// if RunParent() returns early due to a gtest fatal assertion failure, the
// child should still be reaped.
// This will make the parent hang up on the child as much as would be
// visible from the childs perspective. The childs side of the pipe will
// be broken, the childs remote port will become a dead name, and an
// attempt by the child to look up the service will fail. If this werent
// done, the child might hang while waiting for a parent that has already
// triggered a fatal assertion failure to do something.
info.reset();
info_ = nullptr;
int status;
pid_t wait_pid = HANDLE_EINTR(waitpid(pid, &status, 0));
ASSERT_EQ(wait_pid, pid) << ErrnoMessage("waitpid");
TerminationReason reason;
int code;
std::string message;
if (WIFEXITED(status)) {
reason = kTerminationNormal;
code = WEXITSTATUS(status);
message = base::StringPrintf("Child exited with code %d", code);
} else if (WIFSIGNALED(status)) {
reason = kTerminationSignal;
code = WTERMSIG(status);
message =
base::StringPrintf("Child terminated by signal %d (%s)%s",
code,
strsignal(code),
WCOREDUMP(status) ? " (core dumped)" : "");
} else {
FAIL() << base::StringPrintf("Unknown termination reason 0x%x", status);
}
if (reason_ == kTerminationNormal) {
message += base::StringPrintf(", expected exit with code %d", code_);
} else if (reason_ == kTerminationSignal) {
message += base::StringPrintf(", expected termination by signal %d (%s)",
code_,
strsignal(code_));
}
if (reason != reason_ || code != code_) {
ADD_FAILURE() << message;
}
} else {
#if defined(OS_MACOSX)
if (swallow_exceptions) {
ExceptionSwallower::Child_SwallowExceptions();
}
#endif // OS_MACOSX
RunChild();
}
}
void Multiprocess::SetExpectedChildTermination(TerminationReason reason,
int code) {
EXPECT_EQ(info_, nullptr)
<< "SetExpectedChildTermination() must be called before Run()";
reason_ = reason;
code_ = code;
}
Multiprocess::~Multiprocess() {
}
void Multiprocess::PreFork() {
int pipe_fds_c2p[2];
int rv = pipe(pipe_fds_c2p);
ASSERT_EQ(rv, 0) << ErrnoMessage("pipe");
info_->pipe_c2p_read.reset(pipe_fds_c2p[0]);
info_->pipe_c2p_write.reset(pipe_fds_c2p[1]);
int pipe_fds_p2c[2];
rv = pipe(pipe_fds_p2c);
ASSERT_EQ(rv, 0) << ErrnoMessage("pipe");
info_->pipe_p2c_read.reset(pipe_fds_p2c[0]);
info_->pipe_p2c_write.reset(pipe_fds_p2c[1]);
}
pid_t Multiprocess::ChildPID() const {
EXPECT_NE(info_->child_pid, 0);
return info_->child_pid;
}
FileHandle Multiprocess::ReadPipeHandle() const {
int fd = info_->child_pid ? info_->pipe_c2p_read.get()
: info_->pipe_p2c_read.get();
CHECK_NE(fd, -1);
return fd;
}
FileHandle Multiprocess::WritePipeHandle() const {
int fd = info_->child_pid ? info_->pipe_p2c_write.get()
: info_->pipe_c2p_write.get();
CHECK_NE(fd, -1);
return fd;
}
void Multiprocess::CloseReadPipe() {
if (info_->child_pid) {
info_->pipe_c2p_read.reset();
} else {
info_->pipe_p2c_read.reset();
}
}
void Multiprocess::CloseWritePipe() {
if (info_->child_pid) {
info_->pipe_p2c_write.reset();
} else {
info_->pipe_c2p_write.reset();
}
}
void Multiprocess::RunParent() {
// The parent uses the read end of c2p and the write end of p2c.
info_->pipe_c2p_write.reset();
info_->pipe_p2c_read.reset();
MultiprocessParent();
info_->pipe_c2p_read.reset();
info_->pipe_p2c_write.reset();
}
void Multiprocess::RunChild() {
ScopedForbidReturn forbid_return;
// The child uses the write end of c2p and the read end of p2c.
info_->pipe_c2p_read.reset();
info_->pipe_p2c_write.reset();
MultiprocessChild();
info_->pipe_c2p_write.reset();
info_->pipe_p2c_read.reset();
if (testing::Test::HasFailure()) {
// Trigger the ScopedForbidReturn destructor.
return;
}
// In a forked child, exit() is unsafe. Use _exit() instead.
_exit(EXIT_SUCCESS);
}
} // namespace test
} // namespace crashpad