mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 08:39:44 +08:00
6dadd492b8
ProcStatReader.Threads is flaky because it relies on an internal, imprecise measurement of boot time. The flaky test asserts that a thread started after the main thread should have a start time >= the main thread. The start time is returned in a timeval, with microsecond precision, but the measurement of boot time requires two system calls and the time between those system calls can be approximately a microsecond. An unlucky event such as a change in system time could make this imprecision arbitrarily bad. This patch lets the caller of ProcStatReader.StartTime() inject the boot time, allowing ProcStatReader to guarantee that threads have correctly ordered time, given the same input boot time. Bug: 1016765 Change-Id: I6e4a944a1d58c3916090bab6a4b99573e71a89fc Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1891588 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
39 lines
1.1 KiB
C++
39 lines
1.1 KiB
C++
// Copyright 2019 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/misc/time.h"
|
|
|
|
#include "base/logging.h"
|
|
|
|
namespace crashpad {
|
|
|
|
bool GetBootTime(timespec* boot_time) {
|
|
timespec uptime;
|
|
if (clock_gettime(CLOCK_BOOTTIME, &uptime) != 0) {
|
|
PLOG(ERROR) << "clock_gettime";
|
|
return false;
|
|
}
|
|
|
|
timespec current_time;
|
|
if (clock_gettime(CLOCK_REALTIME, ¤t_time) != 0) {
|
|
PLOG(ERROR) << "clock_gettime";
|
|
return false;
|
|
}
|
|
|
|
SubtractTimespec(current_time, uptime, boot_time);
|
|
return true;
|
|
}
|
|
|
|
} // namespace crashpad
|