mirror of
https://github.com/chromium/crashpad.git
synced 2024-12-29 08:39:44 +08:00
cc166d71f4
This is a follow-up to c8a016b99d97, following the post-landing discussion at https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1393921/5#message-2058541d8c4505d20a990ab7734cd758e437a5f7 base::size, and std::size that will eventually replace it when C++17 is assured, does not allow the size of non-static data members to be taken in constant expression context. The remaining uses of ArraySize are in: minidump/minidump_exception_writer.cc (×1) minidump/minidump_system_info_writer.cc (×2, also uses base::size) snapshot/cpu_context.cc (×4, also uses base::size) util/misc/arraysize_test.cc (×10, of course) The first of these occurs when initializing a constexpr variable. All others are in expressions used with static_assert. Includes: Update mini_chromium to 737433ebade4d446643c6c07daae02a67e8deccao f701716d9546 Add Windows ARM64 build target to mini_chromium 87a95a3d6ac2 Remove the arraysize macro 1f7255ead1f7 Placate MSVC in areas of base::size usage 737433ebade4 Add cast Bug: chromium:837308 Change-Id: I6a5162654461b1bdd9b7b6864d0d71a734bcde19 Reviewed-on: https://chromium-review.googlesource.com/c/1396108 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
74 lines
2.4 KiB
C++
74 lines
2.4 KiB
C++
// Copyright 2015 The Crashpad Authors. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "util/misc/random_string.h"
|
|
|
|
#include <sys/types.h>
|
|
|
|
#include <set>
|
|
|
|
#include "base/stl_util.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
namespace crashpad {
|
|
namespace test {
|
|
namespace {
|
|
|
|
TEST(RandomString, RandomString) {
|
|
// Explicitly list the allowed characters, rather than relying on a range.
|
|
// This prevents the test from having any dependency on the character set, so
|
|
// that the implementation is free to assume all uppercase letters are
|
|
// contiguous as in ASCII.
|
|
const std::string allowed_characters("ABCDEFGHIJKLMNOPQRSTUVWXYZ");
|
|
|
|
size_t character_counts[26] = {};
|
|
ASSERT_EQ(allowed_characters.size(), base::size(character_counts));
|
|
|
|
std::set<std::string> strings;
|
|
|
|
for (size_t i = 0; i < 256; ++i) {
|
|
const std::string random_string = RandomString();
|
|
EXPECT_EQ(random_string.size(), 16u);
|
|
|
|
// Make sure that the string is unique. It is possible, but extremely
|
|
// unlikely, for there to be collisions.
|
|
auto result = strings.insert(random_string);
|
|
EXPECT_TRUE(result.second) << random_string;
|
|
|
|
for (char c : random_string) {
|
|
size_t character_index = allowed_characters.find(c);
|
|
|
|
// Make sure that no unexpected characters appear.
|
|
EXPECT_NE(character_index, std::string::npos) << c;
|
|
|
|
if (character_index != std::string::npos) {
|
|
++character_counts[character_index];
|
|
}
|
|
}
|
|
}
|
|
|
|
// Make sure every character appears at least once. It is possible, but
|
|
// extremely unlikely, for a character to not appear at all.
|
|
for (size_t character_index = 0;
|
|
character_index < base::size(character_counts);
|
|
++character_index) {
|
|
EXPECT_GT(character_counts[character_index], 0u)
|
|
<< allowed_characters[character_index];
|
|
}
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace test
|
|
} // namespace crashpad
|